Skip to content

ENH: make all of the properties on LineWrapper mappable #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 10, 2022

Conversation

tacaswell
Copy link
Member

No description provided.

@tacaswell tacaswell changed the title MNT: make all of the properties on LineWrapper mappable ENH: make all of the properties on LineWrapper mappable Nov 4, 2022
@lgtm-com
Copy link

lgtm-com bot commented Nov 4, 2022

This pull request introduces 1 alert when merging 8ee0882 into de25dd1 - view on LGTM.com

new alerts:

  • 1 for Unused import

@ksunden
Copy link
Member

ksunden commented Nov 4, 2022

Running into the difference between Line2D.set_xdata and the existing containers using "x" as the key.

Additionally, the change to LineWrapper probably should escape functions that don't exist (e.g. the animation example has "phase" which is used by other artists, but not the LineWrapper artist, but it is trying to call set_phase)

@tacaswell
Copy link
Member Author

I have some more ideas on this....

@lgtm-com
Copy link

lgtm-com bot commented Nov 4, 2022

This pull request introduces 1 alert when merging e4837b2 into de25dd1 - view on LGTM.com

new alerts:

  • 1 for Unused import

@ksunden ksunden merged commit 3eccc70 into matplotlib:main Nov 10, 2022
@tacaswell tacaswell deleted the nu_line2D branch November 11, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants