Handled non finite values in ax.pie - issue #29860

[AdarshDec]

Closes #29860 issue
Changes makes sure that user gets proper value error message when data contains non finite values and passed into function pie() in lib/matplotlib/axes/_axes.py. Added the condition to check data for any infinite or Nan value, and if encountered one of these, we raise a value error with 'Wedges sizes must be finite numbers'. Also added test_pie_non_finite_values() in tests/test_axes.py for testing the added functionality.

PR summary

PR checklist

• "closes ax.pie() raises ValueError when input contains NaN #29860" is in the body of the PR description to link the related issue
• new and changed code is tested
• [N/A] Plotting related features are demonstrated in an example
• [N/A] New Features and API Changes are noted with a directive and release note
• [N/A] Documentation complies with general and docstring guidelines

[oscargus]

Thanks for your contribution! It seems like you have accidentally added empty lines with spaces and also removed the definition of sx. Other than that, the change and the test seems fine to me.

[github-actions]

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

[AdarshDec]

Thanks for your contribution! It seems like you have accidentally added empty lines with spaces and also removed the definition of sx. Other than that, the change and the test seems fine to me.

Hey, thanks for the review.! Do you want me to update the code according to the suggestions and submit a new PR?

[QuLogic]

There's no need for a new PR; you should update this one with the corrections.

[tacaswell]

The fix + test look good! Can you please clean up the the whitespace/linting issues?

[AdarshDec]

The fix + test look good! Can you please clean up the the whitespace/linting issues?

Yeah, sure!

[timhoffm]

Suggested change

	df = [5, float('nan'), float('inf')]
	values = [5, float('nan'), float('inf')]

Optional. df is typically used as variable name for dataframes, so it's slightly misleading here.

[dstansby]

Thanks a lot for this - it looks like your first PR to Matplotlib, so contratulations on getting it merged!