Implement always compare mode for hash library #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
force-pushed
the
always_compare
branch
3 times, most recently
from
ea3cffc to
80239e0
Compare
|
Needs tests. |
Signed-off-by: Conor MacBride <[email protected]>
Signed-off-by: Conor MacBride <[email protected]>
Signed-off-by: Conor MacBride <[email protected]>
Signed-off-by: Conor MacBride <[email protected]>
|
I've rebased locally and this PR conflicts with #121 so need to need to find a way around that. |
Signed-off-by: Conor MacBride <[email protected]>
ConorMacBride
force-pushed
the
always_compare
branch
from
a8737f1 to
3b6ebef
Compare
|
The hash libraries for mpl20, mpl21, mpl22 and mpl30 are using ft2104 even though Matplotlib apparently hasn't changed the Freetype library in 6 years: https://github.com/matplotlib/matplotlib/blame/085fdd0771c01ccf964459033904d31bf79e611a/lib/matplotlib/__init__.py#L1191 I don't understand how this could have worked before but I'll rename the libraries to have ft261 and update the hashes where necessary. Let me know if I have missed something. |
Signed-off-by: Conor MacBride <[email protected]>
Signed-off-by: Conor MacBride <[email protected]>
Signed-off-by: Conor MacBride <[email protected]>
|
@Cadair Can you review please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for CI so you can see the changes from the reference images even if the hash library has been updated