Skip to content

sqlite3-binding.c is built even when dynamic linking is requested #318

Closed
@marienz

Description

@marienz

Commit 3a55553 added a +build !libsqlite3 constraint to sqlite3-binding.c. Commit 5505c7c replaced sqlite3-binding.c with an unaltered copy of upstream's amalgamation, accidentally removing the build constraint.

Without this constraint, libsqlite3-binding.c is built even when --tags=libsqlite3 is used (requesting dynamically linking to libsqlite3). This unnecessarily increases build times.

I'd send a pull request that just adds the constraint back, but it's very easy to reintroduce this problem the next time the embedded copy of SQLite is upgraded. Some kind of test is required, and I haven't thought of how to write one yet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions