Fixed additional input rows. Added option for Schedule Type. #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule Type to list of available settings.
mcmonkey4eva
reviewed
Dec 5, 2024
| @@ -347,11 +348,11 @@ def show(self, is_img2img): | |||
| return True | |||
|
|
|||
| def ui(self, is_img2img): | |||
| try_init() # Moved to the beginning to ensure modes are registered before UI is built | |||
There was a problem hiding this comment.
(A) it was already at the beginning, the move doesn't really make sense
(B) shouldn't leave change comments in code, make the change in code and leave notes on git
mcmonkey4eva
reviewed
Dec 5, 2024
| @@ -427,7 +428,7 @@ def on_axis_change(mode_name, out_file): | |||
| group_obj = sets[group + 1][0] | |||
| next_rows = sets[group + 1][1] | |||
| def make_vis(prior, r1, r2, r3, r4): | |||
| return gr.Group.update(visible=(prior+r1+r2+r3+r4).strip() != "") | |||
| return gr.update(visible=(prior+r1+r2+r3+r4).strip() != "") | |||
There was a problem hiding this comment.
Why exactly is this change needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed additional input rows. Added option for Schedule Type.