-
Notifications
You must be signed in to change notification settings - Fork 76
DOC: add documentation for Meson arguments #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8ea3b4a
to
fcd1756
Compare
fcd1756
to
dedfc88
Compare
d55fb81
to
ecc4a45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments, these are all kind-of nitpicks. If they are too much for you, I can definitely fix them before merging.
Regarding the pypa/build vs pip commands. We could actually use https://sphinx-design.readthedocs.io/en/latest/tabs.html instead, I think it would look better. They should probably be synchronized tabs too.
Regardless, this is very much appreciated @peter-urban! |
Hi @FFY00, your comments are appreciated! I'll check through your comments in the coming days and apply them one after the other. |
0df1b77
to
1d9f4ca
Compare
Ok, I had surprisingly much time tonight :-D |
1d9f4ca
to
5e7f0f5
Compare
5e7f0f5
to
f373fac
Compare
@FFY00 ... sorry I didn't want to be pushy with the 're-review' request. I mistook the double arrow symbol next to your name as "update" |
f373fac
to
f99ec0d
Compare
f99ec0d
to
0447aff
Compare
I rewrote the examples using the sphinx-design tabs command |
fe44536
to
a34aad2
Compare
No worries at all! FYI pinging me often if something is blocked on me is actually helpful, so not bothered at all by pings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peter-urban thank you so much! This is great!
I just have some final comments, and then we can go ahead and merge this.
Also, if you could remove the points you tackled in the PR from the todo
list at the top of the page, that'd be appreciated.
This is a draft for the (how to) meson-args documentation
a34aad2
to
1370fae
Compare
I adapted your suggestions. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @peter-urban, looks great!
There are just some minor fixups, but I'll apply those via Github's UI and mege 😊
This is a draft for the (how-to) meson-args documentation. It includes an example for using meson install_tags using meson-python's install options (PR #288 and issue #68)
I could not yet answer all todos
(Mention the order in which Meson arguments are added, and how it affect Meson)
and
(Explain how you can add extra Meson arguments via the build config settings)
Feel free to comment on what you like/dislike or directly copy/modify it to you liking