Skip to content

ENH: make the editable install build directory more discoverable #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

dnicolodi
Copy link
Member

@dnicolodi dnicolodi commented Apr 11, 2023

Change the editable install build directory to a subdirectory named after the ABI tag for the target Python interpreter placed in the build directory in the project source directory.

Add .gitignode and .hgignore files with catch all glob patterns to the build directory, if it is empty, to have the major VCS systems ignore it.

Fixes #370, #380.

This implements what has been discussed in #370. I decided to add a subdirectory named as the Python ABI tag as including the platform tag does not seem very useful. I went with build as that seems to be where the consensus seemed to be. I'm not very attached to this choice.

Change the editable install build directory to a subdirectory named
after the ABI tag for the target Python interpreter placed in the
``build`` directory in the project source directory.

Add .gitignode and .hgignore files with catch all glob patterns to the
``build`` directory, if it is empty, to have the major VCS systems
ignore it.

Fixes mesonbuild#370, mesonbuild#380.
@dnicolodi dnicolodi added this to the v0.13.0 milestone Apr 11, 2023
@rgommers rgommers mentioned this pull request Apr 11, 2023
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems to work smoothly for me. Thanks @dnicolodi!

@rgommers rgommers merged commit eacd23a into mesonbuild:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build directory for editable installations
2 participants