Skip to content

MAINT: avoid warnings because of symlinks pointing outside repo #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rgommers
Copy link
Contributor

@rgommers rgommers commented May 5, 2025

Follows up on #728 (comment) and gh-745.

@rgommers rgommers added the maintenance Regular code improvements that are not new features nor end-user-visible bugs label May 5, 2025
@rgommers rgommers force-pushed the distscript-sdist-warnings branch from fa269c5 to ebe7411 Compare May 5, 2025 12:44
@rgommers rgommers added this to the v0.19.0 milestone May 22, 2025
Copy link
Member

@dnicolodi dnicolodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution would be to create the symlinks in the test code. This is simpler, but should we add a note in the test somewhere stating that these test files are not present in the sdist?

@@ -0,0 +1,8 @@
# SPDX-FileCopyrightText: 2021 The meson-python developers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright year seems wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Regular code improvements that are not new features nor end-user-visible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants