Skip to content

mcp: Remove CLI functionality with missing deps (fire, mcp) #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bostrt
Copy link

@bostrt bostrt commented Jun 3, 2025

What does this PR do?

Removes what I believe was test code. Alternative fix is to add fire and mcp as project dependencies.

  File "/home/rbost/code/ifd-backend-api/ifd/core/agents/llama_stack.py", line 8, in <module>
    from llama_stack_client import AsyncLlamaStackClient
  File "/home/rbost/code/ifd-backend-api/.venv/lib/python3.13/site-packages/llama_stack_client/__init__.py", line 42, in <module>
    from .lib.agents.agent import Agent
  File "/home/rbost/code/ifd-backend-api/.venv/lib/python3.13/site-packages/llama_stack_client/lib/__init__.py", line 7, in <module>
    from .tools.mcp_oauth import get_oauth_token_for_mcp_server
  File "/home/rbost/code/ifd-backend-api/.venv/lib/python3.13/site-packages/llama_stack_client/lib/tools/mcp_oauth.py", line 13, in <module>
    import fire
ModuleNotFoundError: No module named 'fire'

Test Plan

I have an application using llama-stack-client-python that was failing to launch due to above stack trace. This PR resolves that stack trace by simply removing the code.

Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will make sure this is added back but with correct optional dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants