update readme #11
Merged
update readme #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,13 @@ To build the tool, simply clone the repo, and run `build.cmd` in command line or | |||
| - `JS.fs`: handles the emitting of the `domWeb.js` and `domWindows.js` | |||
|
|
|||
| ## Contribution Guide | |||
| The `dom.generated.d.ts` and `webworker.generated.d.ts` files that are used in TypeScript repo `master` branch are used as baselines. For each pull request, we will try run the script and compare the generated files with the baseline files. So to make the tests passed, please update the baseline and the code at the same pull request. | |||
| The `dom.generated.d.ts` and `webworker.generated.d.ts` files that are used in TypeScript repo `master` branch are used as baselines. | |||
There was a problem hiding this comment.
used in the TypeScript repository
I think you can remove "master branch" - it's mostly implied
|
@DanielRosenwasser I updated accordingly. Do you have other comments? |
|
👍 |
orta
pushed a commit
to orta/TSJS-lib-generator
that referenced
this pull request
Jun 23, 2021
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.2.0-dev.20201211 to 4.2.0-dev.20201221. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kagami Sascha Rosylight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.