Skip to content

Adds autoGainControl and noiseSuppression properties #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2021

Conversation

paulgalow
Copy link
Contributor

Referring to issue #1148. First PR in this repo. Let me know what I have missed. :)

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor

Refer to https://github.com/microsoft/TypeScript-DOM-lib-generator#when-the-type-is-missing:

If all the conditions are fulfilled, it could be that the type is incorrectly removed by inputfiles/removedTypes.jsonc. Try finding and removing the relevant item there and run npm run build && npm run baseline-accept.

That exactly applies here 😉

@ghost
Copy link

ghost commented Sep 19, 2021

CLA assistant check
All CLA requirements met.

@paulgalow
Copy link
Contributor Author

D'oh! I should have been more suspicious. After all this project has the name "generator" in it 🙃. Hope everything's fine now.

@github-actions github-actions bot merged commit 6f6f9a1 into microsoft:main Sep 19, 2021
@github-actions
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

@paulgalow
Copy link
Contributor Author

Thanks for pointing me in the right direction and also for your blazingly fast response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants