Skip to content

Try forking first before pushing PR #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Try forking first before pushing PR #1153

merged 2 commits into from
Sep 23, 2021

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Sep 19, 2021

To make the bot work with #1127

@saschanaz
Copy link
Contributor Author

Heh, it's natural that PRs modifying workflows can't access secrets.

However, it’s important that the author of a pull request can’t access the repository’s secrets (e.g. by updating a workflow file to print out the secrets instead of running tests).

It's more secure that I thought, and I'm actually relieved!

@saschanaz
Copy link
Contributor Author

So, please merge this when any of you maintainers have a time 😉

@orta
Copy link
Contributor

orta commented Sep 23, 2021

Nice

@orta orta merged commit c00446d into microsoft:main Sep 23, 2021
@saschanaz saschanaz deleted the bot-fork branch September 24, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants