Automate TypeScript Definitions Update from DefinitelyTyped #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eee, I don't think this is a great idea, the DT tests are mega long and we have infra there to shard it. I would think this would fail pretty often because we have to fix DT to work with new DOM types every time in ways that wouldn't be fixable here, e.g. there are packages on DT which exist to provide things that the DOM lib will eventually contain, but then need to be updated once the generated code does actually have things. |
|
Also note that the workflow isn't actually testing anything... Zero tests ran and that's why it appears to be fast. |
|
(In general I think it would be good if we discuss it first before opening PR, to save your time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389
Overrides #1039