Change Event.srcElement type to EventTarget and expose it to Worker
#595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
saschanaz
suggested changes
Nov 1, 2018
|
@saschanaz Could you merge this if there are no other problems with this? |
|
Pinging @sandersn @DanielRosenwasser for this, as I have no write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
Event.srcElementtype toEventTargetand exposes it to Worker. Accepting this PR should close microsoft/TypeScript#28252, however I would like to hear from @mhegazy first as to whyElementtype was chosen. Maybe there's a specific reason I don't know and now I'm ruining everything :).