Skip to content

Warn that inputfiles/idl/ should not be touched manually. #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2019
Merged

Warn that inputfiles/idl/ should not be touched manually. #612

merged 2 commits into from
Jan 24, 2019

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz changed the title Warn that inputfiles/idl/ should be touched manually. Warn that inputfiles/idl/ should not be touched manually. Nov 12, 2018
@HolgerJeromin
Copy link
Contributor

We could add a template, too:

https://help.github.com/articles/about-issue-and-pull-request-templates/

@MattiasBuelens
Copy link
Contributor

Indeed, everything in that directory is generated... except for Streams.widl. 🙈 That file was manually authored in #541 and is explicitly skipped with a local flag in idlSources.json, see cc52c69. Hopefully the Streams spec will switch to Web IDL "soon", then we can get rid of that nasty hack.

However, I still agree that we should recommend not touching anything in that directory. 🙂

@sandersn sandersn merged commit 2a740fc into microsoft:master Jan 24, 2019
@saschanaz saschanaz deleted the dangerzone branch January 25, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschanaz @HolgerJeromin @MattiasBuelens @sandersn