Remove inappropriate IDBKeyRange usages from lib.dom.d.ts. #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hit a compile error because IDBCursor.primaryKey was incorrectly typed as `IDBValidKey | IDBKeyRange` instead of just `IDBValidKey`. I fixed it and manually audited the rest of the instances of `IDBValidKey | IDBKeyRange` and fixed them. If there's a better way to fix these other than manual audit based on my understanding of the IndexedDB API, let me know. -
|
|
saschanaz
approved these changes
Dec 20, 2018
|
Thanks @saschanaz. Who would actually merge this? 😁 |
|
@DanielRosenwasser or @sandersn will do! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit a compile error because IDBCursor.primaryKey was incorrectly typed as
IDBValidKey | IDBKeyRangeinstead of justIDBValidKey. I fixed it andmanually audited the rest of the instances of
IDBValidKey | IDBKeyRangeandfixed them. If there's a better way to fix these other than manual audit based
on my understanding of the IndexedDB API, let me know.
Fixes microsoft/TypeScript#29070