Add ability to use BSD style bracketing

[sheam]

My company uses the C#/BSD style curly braces. I would like a way to have TS auto format in that fashsion, rather than the C/K&R style that it currently does. If there is already a way to do this, I apologize, but I didn't see it in the docs.

[mhegazy]

The typescript formatter allows for this already (using PlaceOpenBraceOnNewLineForFunctions and PlaceOpenBraceOnNewLineForControlBlocks options in https://github.com/Microsoft/TypeScript/blob/master/src/server/protocol.d.ts#L465-L469). the only issue is that this is not exposed any where.
We should allow the server to load these from tsconfig for instance. @zhengbli ideas?

[zhengbli]

I think we should enable both global format setting (in the sublime plugin setting) and project specific setting (in the tsconfig.json file). Something like formatOption property should be added in the config file.

[sheam]

Both would be nice. Most people would likely just use the project setting but, for shared/team projects the tsconfig option would be nice.

[sheam]

I tried setting PlaceOpenBraceOnNewLineForFunctions, and PlaceOpenBraceOnNewLineForControlBlocks both to true in %APPDATA%\Sublime Text 3\Packages\TypeScript\tsserver\tsserver.js, but it doesn't seem to make a difference.

http://screencast-o-matic.com/watch/coXOINh3Ya

Is this setting hooked up to anything? As this is the same behaviour I get when those were set to false. As you can see the it is pretty much unusable if you do BSD bracketing.

[zhengbli]

This is rather wierd, what is your indentation settings? I seem unable to repro with your example:

I tried to indent with both tabs and spaces.

[sheam]

The only settings I have ever touch are User settings (I am new to ST):

{
    "dictionary": "Packages/Language - English/en_GB.dic",
    "hot_exit": false,
    "ignored_packages":
    [
        "Vintage",
    ],
    "remember_open_files": false,
    "typescript_plugin_tsc_version": "1.7.2"
}

The only other setting I have is the tsconfig.json:

{
    "compilerOptions": {
        "sourceMap": true, 
        "target": "es5"
    }
}

Maybe I'll try wiping out my entire installation, including: %APPDATA%\Sublime Text 3, and reinstall and see if that helps.

[zhengbli]

What is your indent setting? It should be showed at the right bottom

[sheam]

My settings are the same as yours.

Wiped everything out and restarted. I notices that I got a warning about a v1.0 TSC when I installed the TS package. I checked my path, and it was picking up TSC from the 1.0 Microsoft SDKs folder. I changed my path to point to the 1.6 compiler, and now everything works as it should. Could the TSC 1.6 be the fix?

The 'npm update -g typescript' didn't seem to do anything.

[sheam]

Now when I perform a format, I get a {CR} glyph where the newline is. If I save and open the file again it is gone, but there is an extra newline in it's place.

[zhengbli]

Though the tsc path should only affect your build process, it has no impact on the language service which power the formatting functions.

The line ending is a known issue (#357) that I haven't got time to investigate yet. Let me look into this soon.

[zhengbli]

OK, it seems the edits resulted from the server is correct (\r\n for windows), but when call view.insert sublime somehow translates the \n to \r\n therefore left an addition CR.

It can be easily fix by replace all the \r\ns to \n (https://github.com/Microsoft/TypeScript-Sublime-Plugin/blob/master/typescript/libs/view_helpers.py#L297):
change

view.insert(text, begin, new_text)

to

view.insert(text, begin, new_text.replace('\r\n', '\n'))

however I'll need to test it on Mac on Monday to make sure it doesn't break them.