Support customized typescript tsdk location #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,11 +50,16 @@ def initialize(self): | |||
| # retrieve the path to tsserver.js | |||
| # first see if user set the path to the file | |||
| settings = sublime.load_settings('Preferences.sublime-settings') | |||
| proc_file = settings.get('typescript_proc_file') | |||
| if not proc_file: | |||
| tsdk_location = settings.get('typescript_tsdk') | |||
|
can you please update the steps in https://github.com/Microsoft/TypeScript/wiki/Nightly-drops#sublime-text after this is merged in. |
| @@ -34,7 +34,9 @@ | |||
| def get_node_path(): | |||
| return _node_path | |||
|
|
|||
| TSC_PATH = os.path.join(PLUGIN_DIR, "tsserver", "tsc.js") | |||
| _tsc_path = None | |||
There was a problem hiding this comment.
There's a comment above that says where _node_path gets initialized. Can you add a similar one here?
|
@mhegazy @DanielRosenwasser @billti further comments? |
|
👍 |
zhengbli
added a commit
that referenced
this pull request
Feb 5, 2016
Support customized typescript tsdk location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it uses the same setting name
typescript_tsdkwith VSCode.Fix #255