"rename file" and "move to new file" refactors do not work when using `files`

[OliverJAsh]

TypeScript Version: 2.9.1

Search Terms:
files "move to new file" "rename file"

Code

// tsconfig.json
{
  "files": ["./src/index.ts"]
}

// ./src/index.ts
import foo from './other';

// ./src/other.ts
export default {}

const bar = {};

Expected behavior:

• When renaming the file ./src/other.ts, I expect TypeScript/VSCode to prompt me to update the import in ./src/index.ts.
• When selecting bar in ./src/other.ts, TypeScript/VSCode offers to move this to a new file. When actioning this, I expect this to work.

(TypeScript knows that ./src/other.ts is in the project because it is part of the traced dependency graph from the entry file ./src/index.ts.)

Actual behavior:

• When renaming the file ./src/other.ts, there is no prompt to update the import.
• When selecting bar in ./src/other.ts, TypeScript/VSCode offers to move this to a new file. When actioning this, nothing happens.

Playground Link:

Related Issues:
microsoft/vscode#51366
#23573
#23726

---

A known workaround is to use the include option instead of files. However, I am curious why this is necessary. I prefer to list the entry file and let TypeScript work the rest out. This is especially helpful when a folder has a combination of source and test files—TypeScript automatically knows not to include the test files because they are not part of the dependency graph.

If there is a good reason why these commands/refactors can't work with files, could we make the experience clearer? Why is the "move to new file" command suggested in VSCode when it leads to nothing? If so, perhaps this is an issue for VSCode.

[mhegazy]

Can you share the log from your tsserver? i suspect it is a duplicate of #24613

[OliverJAsh]

@mhegazy Does this help? tsserver.log

[mhegazy]

This looks different.

[sheetalkamat]

@mjbvz this seems like there are 2 open requests on same file. Can you check why? We do not expect open on same file without closing it first. Thats the assert that raised error in the log.
Interesting open requests:

Info 7    [11:4:3.833] request:
    {"seq":0,"type":"request","command":"open","arguments":{"file":"/Users/OliverJAsh/Development/temp/typescript-files-refactors-test/src/index.ts","fileContent":"// ./src/index.ts\nimport foo from './other';"}}

nfo 52   [11:4:7.163] request:
    {"seq":6,"type":"request","command":"open","arguments":{"file":"/Users/OliverJAsh/Development/temp/typescript-files-refactors-test/src/index.ts","fileContent":"// ./src/index.ts\nimport foo from './other';","scriptKindName":"TS","projectRootPath":"/Users/OliverJAsh/Development/temp/typescript-files-refactors-test"}}

[mjbvz]

@OliverJAsh Can you please try collecting the TS Server log again in the latest VS Code insiders build. I made some changes to how we track opened files and haven't been able to reproduce the duplicate open requests in recent VS Code builds

[OliverJAsh]

@mjbvz In this log I attempt to use the "move to new file" command as described in my original post.
tsserver.log

@mjbvz Are you able to reproduce the issue as I described?

[mhegazy]

@OliverJAsh looks like this log is using typescript@2.9.1 can you try with typescript@next?

[sheetalkamat]

@OliverJAsh The error you are seeing in the log, i think is fixed by #24613. Please try typescript@next and let us know if you still see the issue. Thank you.