[NewErrors] 4.1.0-dev.20201101 vs 4.0.5

[typescript-bot]

The following errors were reported by 4.1.0-dev.20201101, but not by 4.0.5

vscode

6 of 43 projects failed to build with the old tsc

test/smoke/tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • test/smoke/src/main.ts#L271
  • test/smoke/src/main.ts#L274

puppeteer

4 of 8 projects failed to build with the old tsc

scripts/tsconfig.json

• error TS2322: Type '(value: boolean | PromiseLike<boolean>) => void' is not assignable to type '() => void'.
  • src/common/Target.ts#L95

tsconfig.json

• error TS2322: Type '(value: boolean | PromiseLike<boolean>) => void' is not assignable to type '() => void'.
  • src/common/Target.ts#L95

src/tsconfig.cjs.json

• error TS2322: Type '(value: boolean | PromiseLike<boolean>) => void' is not assignable to type '() => void'.
  • src/common/Target.ts#L95 in src/tsconfig.cjs.json

src/tsconfig.esm.json

• error TS2322: Type '(value: boolean | PromiseLike<boolean>) => void' is not assignable to type '() => void'.
  • src/common/Target.ts#L95 in src/tsconfig.esm.json

hyper

1 of 2 projects failed to build with the old tsc

tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • app/utils/cli-install.ts#L69 in app/tsconfig.json
  • app/utils/cli-install.ts#L82 in app/tsconfig.json

nativefier

tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • src/helpers/helpers.ts#L48

rxjs

7 of 11 projects failed to build with the old tsc

src/tsconfig.cjs.spec.json

• error TS2322: Type '(value: T | PromiseLike<T>) => void' is not assignable to type '(value?: T | PromiseLike<T> | undefined) => void'.
  • src/internal/util/deferred.ts#L5

src/tsconfig.esm5.rollup.json

• error TS2322: Type '(value: T | PromiseLike<T>) => void' is not assignable to type '(value?: T | PromiseLike<T> | undefined) => void'.
  • src/internal/util/deferred.ts#L5

react-navigation

packages/bottom-tabs/tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • packages/native/src/useLinking.tsx#L159 in packages/native/tsconfig.json

packages/compat/tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • packages/native/src/useLinking.tsx#L159 in packages/native/tsconfig.json

packages/drawer/tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • packages/native/src/useLinking.tsx#L159 in packages/native/tsconfig.json

packages/material-bottom-tabs/tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • packages/native/src/useLinking.tsx#L159 in packages/native/tsconfig.json

packages/material-top-tabs/tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • packages/native/src/useLinking.tsx#L159 in packages/native/tsconfig.json

packages/stack/tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • packages/native/src/useLinking.tsx#L159 in packages/native/tsconfig.json

tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • packages/native/src/useLinking.tsx#L159 in tsconfig.json

playwright

3 of 4 projects failed to build with the old tsc

src/install/tsconfig.json

• error TS2322: Type '(value: unknown) => void' is not assignable to type '() => void'.
  • src/install/browserFetcher.ts#L198

terminus

14 of 17 projects failed to build with the old tsc

terminus-core/tsconfig.typings.json

• error TS1243: 'async' modifier cannot be used with 'abstract' modifier.
  • terminus-core/src/api/tabContextMenuProvider.ts#L10
  • terminus-core/src/api/tabRecovery.ts#L43

terminus-terminal/tsconfig.typings.json

• error TS1243: 'async' modifier cannot be used with 'abstract' modifier.
  • terminus-terminal/src/api/colorSchemeProvider.ts#L7
  • terminus-terminal/src/api/contextMenuProvider.ts#L10
  • terminus-terminal/src/api/shellProvider.ts#L7
  • terminus-terminal/src/services/sessions.service.ts#L88
  • terminus-terminal/src/services/sessions.service.ts#L89
  • terminus-terminal/src/services/sessions.service.ts#L90
• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • terminus-terminal/src/services/sessions.service.ts#L252
  • terminus-terminal/src/services/sessions.service.ts#L255

tools

tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • internal/cli-reporter/Reporter.ts#L479
  • internal/cli-reporter/select.ts#L242
  • internal/core/client/Client.ts#L689
  • internal/core/client/Client.ts#L725
  • internal/core/client/Client.ts#L783
  • internal/core/server/fs/RecoveryStore.ts#L522
  • public-packages/vscode-extension/index.ts#L133
• error TS2345: Argument of type '(value: unknown) => void' is not assignable to parameter of type '() => void'.
  • internal/core/server/lsp/LSPServer.test.ts#L57

fingerprintjs

tsconfig.json

• error TS2322: Type 'unknown' is not assignable to type 'boolean'.
  • src/sources/audio.ts#L5
• error TS2345: Argument of type 'readonly string[]' is not assignable to parameter of type 'string[]'.
  • src/sources/languages.ts#L17

redux-devtools

9 of 50 projects failed to build with the old tsc

packages/react-json-tree/test/tsconfig.json

• error TS2554: Expected 0-1 arguments, but got 2.
  • packages/react-json-tree/src/createStylingFromTheme.ts#L204
• error TS2769: No overload matches this call.
  • packages/react-json-tree/src/index.tsx#L101

packages/react-json-tree/tsconfig.json

• error TS2554: Expected 0-1 arguments, but got 2.
  • packages/react-json-tree/src/createStylingFromTheme.ts#L204
• error TS2769: No overload matches this call.
  • packages/react-json-tree/src/index.tsx#L101

packages/redux-devtools-inspector-monitor/demo/tsconfig.json

• error TS2769: No overload matches this call.
  • packages/redux-devtools-inspector-monitor/src/DevtoolsInspector.tsx#L126
• error TS2554: Expected 0-1 arguments, but got 2.
  • packages/redux-devtools-inspector-monitor/src/utils/createStylingFromTheme.ts#L409

packages/redux-devtools-inspector-monitor/tsconfig.json

• error TS2769: No overload matches this call.
  • packages/redux-devtools-inspector-monitor/src/DevtoolsInspector.tsx#L126
• error TS2554: Expected 0-1 arguments, but got 2.
  • packages/redux-devtools-inspector-monitor/src/utils/createStylingFromTheme.ts#L409

packages/redux-devtools-inspector-monitor-trace-tab/test/tsconfig.json

• error TS2322: Type 'unknown' is not assignable to type 'boolean | undefined'.
  • packages/redux-devtools-inspector-monitor-trace-tab/src/StackTraceTab.tsx#L86
• error TS2345: Argument of type '(value: unknown) => void' is not assignable to parameter of type '() => void'.
  • packages/redux-devtools-inspector-monitor-trace-tab/test/StackTraceTab.spec.tsx#L38
  • packages/redux-devtools-inspector-monitor-trace-tab/test/StackTraceTab.spec.tsx#L47
  • packages/redux-devtools-inspector-monitor-trace-tab/test/StackTraceTab.spec.tsx#L56
  • packages/redux-devtools-inspector-monitor-trace-tab/test/StackTraceTab.spec.tsx#L65

packages/redux-devtools-inspector-monitor-trace-tab/tsconfig.json

• error TS2322: Type 'unknown' is not assignable to type 'boolean | undefined'.
  • packages/redux-devtools-inspector-monitor-trace-tab/src/StackTraceTab.tsx#L86

packages/redux-devtools-cli/test/tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • packages/redux-devtools-cli/test/integration.spec.ts#L28
  • packages/redux-devtools-cli/test/integration.spec.ts#L70
  • packages/redux-devtools-cli/test/integration.spec.ts#L125
  • packages/redux-devtools-cli/test/integration.spec.ts#L160
  • packages/redux-devtools-cli/test/integration.spec.ts#L179
  • packages/redux-devtools-cli/test/integration.spec.ts#L202
  • packages/redux-devtools-cli/test/integration.spec.ts#L236

face-api.js

tsconfig.es6.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • src/dom/awaitMediaLoaded.ts#L8
• error TS2345: Argument of type '{ detection: FaceDetection; } | undefined' is not assignable to parameter of type '{ detection: FaceDetection; } | PromiseLike<{ detection: FaceDetection; }>'.
  • src/globalApi/DetectFacesTasks.ts#L100
• error TS2349: This expression is not callable.
  • src/resizeResults.ts#L16
• error TS7006: Parameter 'obj' implicitly has an 'any' type.
  • src/resizeResults.ts#L16

tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • src/dom/awaitMediaLoaded.ts#L8
• error TS2345: Argument of type '{ detection: FaceDetection; } | undefined' is not assignable to parameter of type '{ detection: FaceDetection; } | PromiseLike<{ detection: FaceDetection; }>'.
  • src/globalApi/DetectFacesTasks.ts#L100
• error TS2349: This expression is not callable.
  • src/resizeResults.ts#L16
• error TS7006: Parameter 'obj' implicitly has an 'any' type.
  • src/resizeResults.ts#L16

tsconfig.test.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • src/dom/awaitMediaLoaded.ts#L8
• error TS2345: Argument of type '{ detection: FaceDetection; } | undefined' is not assignable to parameter of type '{ detection: FaceDetection; } | PromiseLike<{ detection: FaceDetection; }>'.
  • src/globalApi/DetectFacesTasks.ts#L100
• error TS2349: This expression is not callable.
  • src/resizeResults.ts#L16
• error TS7006: Parameter 'obj' implicitly has an 'any' type.
  • src/resizeResults.ts#L16

Tone.js

scripts/tsconfig.build.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • Tone/component/channel/Recorder.ts#L118
• error TS1243: 'async' modifier cannot be used with 'abstract' modifier.
  • Tone/core/context/BaseContext.ts#L80

tsconfig.json

• error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?
  • Tone/component/channel/Recorder.ts#L118
  • Tone/core/context/Context.test.ts#L115
• error TS1243: 'async' modifier cannot be used with 'abstract' modifier.
  • Tone/core/context/BaseContext.ts#L80

[tchetwin]

I think I just ran into this, was about to enter a new Issue but the keyword search step helped me find this (kudos!):

4.1.0-dev.20201028 succeeds
4.1.0-dev.20201029 fails

import { promisify } from "util";

// These are components of @types/xml2js@0.4.5
export interface convertableToString {
    toString(): string;
}
declare class Parser {
    // `cb` isn't great, origin: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/87abb796d1ca0367185a86a580c8b5a5150296c8/types/xml2js/index.d.ts#L33
    parseString(str: convertableToString, cb?: Function): void;
}

const xmlParser = new Parser();
const parseString = xmlParser.parseString.bind(xmlParser);
const parseStringP = promisify(parseString);

// This errors in Nightly (v4.2.0-dev.20201103), succeeds in v4.1.0-beta
parseStringP("abc");

In the success case, this promisify overload is selected:

(alias) promisify<convertableToString, unknown>(fn: (arg1: convertableToString, callback: (err: any, result: unknown) => void) => void): (arg1: convertableToString) => Promise<...> (+13 overloads)

... resulting in a bad parseStringP signature.

In the fail:

(alias) promisify<unknown>(fn: (callback: (err: any, result: unknown) => void) => void): () => Promise<unknown> (+13 overloads)

---

Edit: I see the majority of these failures were already in #41235 and #41155 before that. I can open this as a standalone Issue if needed.

[RyanCavanaugh]

@tchetwin please open a fresh issue; thanks!