Skip to content

quick fix of indexed access #20956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2018
Merged

quick fix of indexed access #20956

merged 1 commit into from
Jan 4, 2018

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jan 2, 2018

Fixes #20833

@Kingwl Kingwl force-pushed the quick-fix-indexed-access branch from 0fe6d60 to 5d146e6 Compare January 2, 2018 06:16
@RyanCavanaugh
Copy link
Member

What's the explanation for why the assert was wrong?

@Kingwl Kingwl force-pushed the quick-fix-indexed-access branch from 5d146e6 to fc7d456 Compare January 3, 2018 02:36
@Kingwl
Copy link
Contributor Author

Kingwl commented Jan 3, 2018 •
edited
Loading

ping @RyanCavanaugh
updated
because includeJsDocComment is false then token is redirected to function keyword
happy new year 😄

@mhegazy mhegazy merged commit 2ea5f58 into microsoft:master Jan 4, 2018
@Kingwl Kingwl deleted the quick-fix-indexed-access branch January 5, 2018 04:26
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kingwl @RyanCavanaugh @mhegazy