Skip to content

Properly preserve numeric string named properties in declaration files #39658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

ahejlsberg
Copy link
Member

Fixes #37292.

@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 18, 2020

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at ff10f69. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 18, 2020

Heya @ahejlsberg, I've started to run the extended test suite on this PR at ff10f69. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 18, 2020

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at ff10f69. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg
Copy link
Member Author

Tests look good. Only a single change in the error baselines for chrome-devtools-frontend, other errors are preexisting conditions.

@ahejlsberg ahejlsberg merged commit 5ae4b5d into master Jul 20, 2020
@ahejlsberg ahejlsberg deleted the fix37292 branch July 20, 2020 17:36
@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storing a keyof to a string quoted number key produces TS2344: invalid constraint in declaration file
3 participants