🤖 Sync option descriptions <- website #46465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gabritto merged 2 commits into microsoft:main from jablko:sync-option-descriptions

Mar 8, 2022

Contributor

jablko commented Oct 21, 2021 •

edited

Loading

Get command-line option descriptions from the website Markdown and update their corresponding descriptions in the compiler.

jablko force-pushed the sync-option-descriptions branch from 9e4ad36 to 45137e4 Compare

October 21, 2021 19:02

typescript-bot added the For Uncommitted Bug label

Collaborator

typescript-bot commented Oct 21, 2021

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

jablko marked this pull request as draft

October 21, 2021 19:05

Contributor

orta commented Oct 21, 2021

you might have changed the line endings on the JSON file - the diff is basically the file

https://twitter.com/kclemson/status/1451238009664278528

jablko force-pushed the sync-option-descriptions branch from 45137e4 to 3a921d7 Compare

October 21, 2021 20:49

Contributor Author

jablko commented Oct 21, 2021

Thanks! I've now added .replace(/\n/g, "\r\n")

jablko force-pushed the sync-option-descriptions branch 7 times, most recently from f3ba7a7 to 5c12658 Compare

October 22, 2021 18:07

jablko changed the title ~~🤖 Sync option descriptions <- jablko/TypeScript-Website~~ 🤖 Sync option descriptions <- website

jablko marked this pull request as ready for review

October 23, 2021 00:26

jablko force-pushed the sync-option-descriptions branch from c9a620e to 9dd95d3 Compare

November 10, 2021 15:51

sandersn requested a review from orta

November 17, 2021 23:56

sandersn assigned orta

jablko force-pushed the sync-option-descriptions branch 3 times, most recently from fd400dd to 1d05a00 Compare

February 7, 2022 15:37

jablko commented

View reviewed changes

src/compiler/commandLineParser.ts

@@ @@ -288,7 +288,7 @@ namespace ts { @@
                           shortName: "i",
                           type: "boolean",
                           category: Diagnostics.Projects,
-                          description: Diagnostics.Enable_incremental_compilation,
+                          description: Diagnostics.Save_tsbuildinfo_files_to_allow_for_incremental_compilation_of_projects,

Contributor Author

jablko Feb 7, 2022

The new description was added -> diagnosticMessages.json in https://github.com/microsoft/TypeScript/pull/44409/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43effR5336

src/compiler/commandLineParser.ts

@@ @@ -693,7 +693,7 @@ namespace ts { @@
                           affectsSemanticDiagnostics: true,
                           strictFlag: true,
                           category: Diagnostics.Type_Checking,
-                          description: Diagnostics.Type_catch_clause_variables_as_unknown_instead_of_any,

Contributor Author

jablko Feb 7, 2022

07a9e49#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43effR5098

src/compiler/commandLineParser.ts

@@ @@ -693,7 +693,7 @@ namespace ts { @@
                           affectsSemanticDiagnostics: true,
                           strictFlag: true,
                           category: Diagnostics.Type_Checking,
-                          description: Diagnostics.Type_catch_clause_variables_as_unknown_instead_of_any,
+                          description: Diagnostics.Default_catch_clause_variables_as_unknown_instead_of_any,

Contributor Author

jablko Feb 7, 2022

microsoft/TypeScript-Website@7efa547#diff-c4f431e3b61bc662f3a9199fed964ef98c1d8085f4d3b5d0a805e489de76fd45R3

src/compiler/commandLineParser.ts

@@ @@ -712,7 +712,7 @@ namespace ts { @@
                           type: "boolean",
                           affectsSemanticDiagnostics: true,
                           category: Diagnostics.Type_Checking,
-                          description: Diagnostics.Enable_error_reporting_when_a_local_variables_aren_t_read,
+                          description: Diagnostics.Enable_error_reporting_when_local_variables_aren_t_read,

Contributor Author

jablko Feb 7, 2022

Grammar fix from https://github.com/microsoft/TypeScript-Website/pull/2185/files#diff-e5259979e1c7767404f2f1f8992c01ad04cea5a8c52dd9bffc52160fbf220beeR3

src/compiler/commandLineParser.ts Outdated Show resolved Hide resolved

src/compiler/commandLineParser.ts Outdated Show resolved Hide resolved

src/compiler/commandLineParser.ts

@@ @@ -753,7 +753,7 @@ namespace ts { @@
                           type: "boolean",
                           affectsSemanticDiagnostics: true,
                           category: Diagnostics.Type_Checking,
-                          description: Diagnostics.Include_undefined_in_index_signature_results,
+                          description: Diagnostics.Add_undefined_to_a_type_when_accessed_using_an_index,

Contributor Author

jablko Feb 7, 2022

The new description was added -> diagnosticMessages.json in https://github.com/microsoft/TypeScript/pull/44409/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43effR5464

src/compiler/commandLineParser.ts

@@ @@ -1234,7 +1234,7 @@ namespace ts { @@
                               name: "plugin",
                               type: "object"
                           },
-                          description: Diagnostics.List_of_language_service_plugins,
+                          description: Diagnostics.Specify_a_list_of_language_service_plugins_to_include,

Contributor Author

jablko Feb 7, 2022

The new description was added -> diagnosticMessages.json in https://github.com/microsoft/TypeScript/pull/44409/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43effR5492

jablko mentioned this pull request

Sync exactOptionalPropertyTypes description <- compiler microsoft/TypeScript-Website#2258

Merged

jablko force-pushed the sync-option-descriptions branch 3 times, most recently from a08f40c to 5be2def Compare

February 16, 2022 14:54

jablko force-pushed the sync-option-descriptions branch from 8073d7e to 4e0dc98 Compare

February 20, 2022 01:18

sandersn requested review from gabritto and removed request for orta

February 25, 2022 02:30

sandersn assigned gabritto and unassigned orta

jablko force-pushed the sync-option-descriptions branch from 66bad71 to 4b7a341 Compare

March 6, 2022 01:18

gabritto reviewed

View reviewed changes

tests/baselines/reference/classStaticBlock22.errors.txt

		@@ -1,94 +0,0 @@
		tests/cases/conformance/classes/classStaticBlock/classStaticBlock22.ts(4,9): error TS1359: Identifier expected. 'await' is a reserved word that cannot be used here.

Member

gabritto Mar 7, 2022

why have this and a bunch of other files been deleted?

Contributor Author

jablko Mar 7, 2022

@gabritto Hi! They're baselines for tests that no longer exist --- they're removed by the Accept Baselines and Fix Lints workflow:

TypeScript/.github/workflows/accept-baselines-fix-lints.yaml

Line 23 in 6aaefe4

git rm -r --quiet tests/baselines/reference :^tests/baselines/reference/docker :^tests/baselines/reference/user
Remove vestigial baselines #45916

sandersn reviewed

View reviewed changes

src/compiler/diagnosticMessages.json Outdated

@@ @@ -879,7 +879,6 @@ @@
                       "category": "Error",
                       "code": 1271
                   },

Member

sandersn Mar 8, 2022

the whitespace here is a little useful for pointing out the gap between 1271 and 1300. I'd prefer to keep it and the others that are like it.

gabritto requested changes

View reviewed changes

Member

gabritto left a comment

minor comment about empty lines, but other than that I think we're good to go

src/compiler/diagnosticMessages.json Outdated

@@ @@ -879,7 +879,6 @@ @@
                       "category": "Error",
                       "code": 1271
                   },

Member

gabritto Mar 8, 2022

as Nathan commented, please leave the blank lines as-is

Contributor Author

jablko Mar 8, 2022

@gabritto Thanks! I've restored the blank lines.


          🤖 Sync option descriptions <- jablko/TypeScript-Website@a9df513

ba9ba2b

https://github.com/jablko/TypeScript-Website/actions/runs/1953829438

jablko force-pushed the sync-option-descriptions branch from aaeb257 to ba9ba2b Compare

March 8, 2022 21:10


          Update Baselines and/or Applied Lint Fixes

9133ed7

gabritto approved these changes

View reviewed changes

gabritto merged commit 94a7ec1 into microsoft:main

sandersn mentioned this pull request

fix(48053) Description of tsBuildInfoFile is misleading in generated tsconfig.json #48072

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Uncommitted Bug