Skip to content

Fix node16 tests for module resolution #48974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022
Merged

Fix node16 tests for module resolution #48974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/testRunner/unittests/tsbuild/moduleResolution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ namespace ts.tscWatch {
path: `${projectRoot}/node_modules/pkg2`,
symLink: `${projectRoot}/packages/pkg2`,
},
{ ...libFile, path: `/a/lib/lib.es2020.full.d.ts` }
{ ...libFile, path: `/a/lib/lib.es2022.full.d.ts` }
], { currentDirectory: projectRoot }),
commandLineArgs: ["-b", "packages/pkg1", "-w", "--verbose", "--traceResolution"],
changes: [
Expand Down
2 changes: 1 addition & 1 deletion src/testRunner/unittests/tsbuild/moduleSpecifiers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ namespace ts {
}`,
}, ""),
modifyFs: fs => {
fs.writeFileSync("/lib/lib.es2020.full.d.ts", tscWatch.libFile.content);
fs.writeFileSync("/lib/lib.es2022.full.d.ts", tscWatch.libFile.content);
fs.symlinkSync("/src", "/src/src-types/node_modules");
fs.symlinkSync("/src", "/src/src-dogs/node_modules");
},
Expand Down
299 changes: 281 additions & 18 deletions ...build/moduleSpecifiers/synthesized-module-specifiers-across-projects-resolve-correctly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface Array<T> { length: number; [n: number]: T; }
interface ReadonlyArray<T> {}
declare const console: { log(msg: any): void; };

//// [/lib/lib.es2020.full.d.ts]
//// [/lib/lib.es2022.full.d.ts]
/// <reference no-default-lib="true"/>
interface Boolean {}
interface Function {}
Expand Down Expand Up @@ -134,33 +134,296 @@ Output::

[12:00:26 AM] Building project '/src/src-types/tsconfig.json'...

error TS6053: File '/lib/lib.es2022.full.d.ts' not found.
The file is in the program because:
Default library for target 'es2022'
[12:00:33 AM] Project 'src/src-dogs/tsconfig.json' is out of date because output file 'src/src-dogs/dog.js' does not exist

error TS2318: Cannot find global type 'Array'.
[12:00:34 AM] Building project '/src/src-dogs/tsconfig.json'...

error TS2318: Cannot find global type 'Boolean'.
exitCode:: ExitStatus.Success


//// [/src/src-dogs/dog.d.ts]
import { DogConfig } from 'src-types';
export declare abstract class Dog {
static getCapabilities(): DogConfig;
}

error TS2318: Cannot find global type 'Function'.

error TS2318: Cannot find global type 'IArguments'.
//// [/src/src-dogs/dog.js]
import { DOG_CONFIG } from './dogconfig.js';
export class Dog {
static getCapabilities() {
return DOG_CONFIG;
}
}

error TS2318: Cannot find global type 'Number'.

error TS2318: Cannot find global type 'Object'.
//// [/src/src-dogs/dogconfig.d.ts]
import { DogConfig } from 'src-types';
export declare const DOG_CONFIG: DogConfig;

error TS2318: Cannot find global type 'RegExp'.

error TS2318: Cannot find global type 'String'.
//// [/src/src-dogs/dogconfig.js]
export const DOG_CONFIG = {
name: 'Default dog',
};

[12:00:27 AM] Project 'src/src-dogs/tsconfig.json' can't be built because its dependency 'src/src-types' has errors

[12:00:28 AM] Skipping build of project '/src/src-dogs/tsconfig.json' because its dependency '/src/src-types' has errors
//// [/src/src-dogs/index.d.ts]
export * from 'src-types';
export * from './lassie/lassiedog.js';


Found 9 errors.
//// [/src/src-dogs/index.js]
export * from 'src-types';
export * from './lassie/lassiedog.js';


//// [/src/src-dogs/lassie/lassieconfig.d.ts]
import { DogConfig } from 'src-types';
export declare const LASSIE_CONFIG: DogConfig;


//// [/src/src-dogs/lassie/lassieconfig.js]
export const LASSIE_CONFIG = { name: 'Lassie' };


//// [/src/src-dogs/lassie/lassiedog.d.ts]
import { Dog } from '../dog.js';
export declare class LassieDog extends Dog {
protected static getDogConfig: () => import("../index.js").DogConfig;
}


//// [/src/src-dogs/lassie/lassiedog.js]
import { Dog } from '../dog.js';
import { LASSIE_CONFIG } from './lassieconfig.js';
export class LassieDog extends Dog {
static getDogConfig = () => LASSIE_CONFIG;
}


//// [/src/src-dogs/tsconfig.tsbuildinfo]
{"program":{"fileNames":["../../lib/lib.es2022.full.d.ts","../src-types/dogconfig.d.ts","../src-types/index.d.ts","./dogconfig.ts","./dog.ts","./lassie/lassieconfig.ts","./lassie/lassiedog.ts","./index.ts"],"fileInfos":[{"version":"-7698705165-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }","affectsGlobalScope":true,"impliedFormat":1},{"version":"-2632060142-export interface DogConfig {\r\n name: string;\r\n}\r\n","impliedFormat":99},{"version":"-5608794531-export * from './dogconfig.js';\r\n","impliedFormat":99},{"version":"1966273863-import { DogConfig } from 'src-types';\n\nexport const DOG_CONFIG: DogConfig = {\n name: 'Default dog',\n};\n","signature":"17588480778-import { DogConfig } from 'src-types';\r\nexport declare const DOG_CONFIG: DogConfig;\r\n","impliedFormat":99},{"version":"6091345804-import { DogConfig } from 'src-types';\nimport { DOG_CONFIG } from './dogconfig.js';\n\nexport abstract class Dog {\n\n public static getCapabilities(): DogConfig {\n return DOG_CONFIG;\n }\n}\n","signature":"22128633249-import { DogConfig } from 'src-types';\r\nexport declare abstract class Dog {\r\n static getCapabilities(): DogConfig;\r\n}\r\n","impliedFormat":99},{"version":"4440579024-import { DogConfig } from 'src-types';\n\nexport const LASSIE_CONFIG: DogConfig = { name: 'Lassie' };\n","signature":"8131483665-import { DogConfig } from 'src-types';\r\nexport declare const LASSIE_CONFIG: DogConfig;\r\n","impliedFormat":99},{"version":"-32303727812-import { Dog } from '../dog.js';\nimport { LASSIE_CONFIG } from './lassieconfig.js';\n\nexport class LassieDog extends Dog {\n protected static getDogConfig = () => LASSIE_CONFIG;\n}\n","signature":"-20244062422-import { Dog } from '../dog.js';\r\nexport declare class LassieDog extends Dog {\r\n protected static getDogConfig: () => import(\"../index.js\").DogConfig;\r\n}\r\n","impliedFormat":99},{"version":"-15974991320-export * from 'src-types';\nexport * from './lassie/lassiedog.js';\n","signature":"-16783836862-export * from 'src-types';\r\nexport * from './lassie/lassiedog.js';\r\n","impliedFormat":99}],"options":{"composite":true,"declaration":true,"module":100},"fileIdsList":[[3,4],[3],[3,7],[5,6],[2],[5,8]],"referencedMap":[[5,1],[4,2],[8,3],[6,2],[7,4],[3,5]],"exportedModulesMap":[[5,2],[4,2],[8,3],[6,2],[7,6],[3,5]],"semanticDiagnosticsPerFile":[1,5,4,8,6,7,2,3]},"version":"FakeTSVersion"}

//// [/src/src-dogs/tsconfig.tsbuildinfo.readable.baseline.txt]
{
"program": {
"fileNames": [
"../../lib/lib.es2022.full.d.ts",
"../src-types/dogconfig.d.ts",
"../src-types/index.d.ts",
"./dogconfig.ts",
"./dog.ts",
"./lassie/lassieconfig.ts",
"./lassie/lassiedog.ts",
"./index.ts"
],
"fileNamesList": [
[
"../src-types/index.d.ts",
"./dogconfig.ts"
],
[
"../src-types/index.d.ts"
],
[
"../src-types/index.d.ts",
"./lassie/lassiedog.ts"
],
[
"./dog.ts",
"./lassie/lassieconfig.ts"
],
[
"../src-types/dogconfig.d.ts"
],
[
"./dog.ts",
"./index.ts"
]
],
"fileInfos": {
"../../lib/lib.es2022.full.d.ts": {
"version": "-7698705165-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }",
"signature": "-7698705165-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }",
"affectsGlobalScope": true,
"impliedFormat": 1
},
"../src-types/dogconfig.d.ts": {
"version": "-2632060142-export interface DogConfig {\r\n name: string;\r\n}\r\n",
"signature": "-2632060142-export interface DogConfig {\r\n name: string;\r\n}\r\n",
"impliedFormat": 99
},
"../src-types/index.d.ts": {
"version": "-5608794531-export * from './dogconfig.js';\r\n",
"signature": "-5608794531-export * from './dogconfig.js';\r\n",
"impliedFormat": 99
},
"./dogconfig.ts": {
"version": "1966273863-import { DogConfig } from 'src-types';\n\nexport const DOG_CONFIG: DogConfig = {\n name: 'Default dog',\n};\n",
"signature": "17588480778-import { DogConfig } from 'src-types';\r\nexport declare const DOG_CONFIG: DogConfig;\r\n",
"impliedFormat": 99
},
"./dog.ts": {
"version": "6091345804-import { DogConfig } from 'src-types';\nimport { DOG_CONFIG } from './dogconfig.js';\n\nexport abstract class Dog {\n\n public static getCapabilities(): DogConfig {\n return DOG_CONFIG;\n }\n}\n",
"signature": "22128633249-import { DogConfig } from 'src-types';\r\nexport declare abstract class Dog {\r\n static getCapabilities(): DogConfig;\r\n}\r\n",
"impliedFormat": 99
},
"./lassie/lassieconfig.ts": {
"version": "4440579024-import { DogConfig } from 'src-types';\n\nexport const LASSIE_CONFIG: DogConfig = { name: 'Lassie' };\n",
"signature": "8131483665-import { DogConfig } from 'src-types';\r\nexport declare const LASSIE_CONFIG: DogConfig;\r\n",
"impliedFormat": 99
},
"./lassie/lassiedog.ts": {
"version": "-32303727812-import { Dog } from '../dog.js';\nimport { LASSIE_CONFIG } from './lassieconfig.js';\n\nexport class LassieDog extends Dog {\n protected static getDogConfig = () => LASSIE_CONFIG;\n}\n",
"signature": "-20244062422-import { Dog } from '../dog.js';\r\nexport declare class LassieDog extends Dog {\r\n protected static getDogConfig: () => import(\"../index.js\").DogConfig;\r\n}\r\n",
"impliedFormat": 99
},
"./index.ts": {
"version": "-15974991320-export * from 'src-types';\nexport * from './lassie/lassiedog.js';\n",
"signature": "-16783836862-export * from 'src-types';\r\nexport * from './lassie/lassiedog.js';\r\n",
"impliedFormat": 99
}
},
"options": {
"composite": true,
"declaration": true,
"module": 100
},
"referencedMap": {
"./dog.ts": [
"../src-types/index.d.ts",
"./dogconfig.ts"
],
"./dogconfig.ts": [
"../src-types/index.d.ts"
],
"./index.ts": [
"../src-types/index.d.ts",
"./lassie/lassiedog.ts"
],
"./lassie/lassieconfig.ts": [
"../src-types/index.d.ts"
],
"./lassie/lassiedog.ts": [
"./dog.ts",
"./lassie/lassieconfig.ts"
],
"../src-types/index.d.ts": [
"../src-types/dogconfig.d.ts"
]
},
"exportedModulesMap": {
"./dog.ts": [
"../src-types/index.d.ts"
],
"./dogconfig.ts": [
"../src-types/index.d.ts"
],
"./index.ts": [
"../src-types/index.d.ts",
"./lassie/lassiedog.ts"
],
"./lassie/lassieconfig.ts": [
"../src-types/index.d.ts"
],
"./lassie/lassiedog.ts": [
"./dog.ts",
"./index.ts"
],
"../src-types/index.d.ts": [
"../src-types/dogconfig.d.ts"
]
},
"semanticDiagnosticsPerFile": [
"../../lib/lib.es2022.full.d.ts",
"./dog.ts",
"./dogconfig.ts",
"./index.ts",
"./lassie/lassieconfig.ts",
"./lassie/lassiedog.ts",
"../src-types/dogconfig.d.ts",
"../src-types/index.d.ts"
]
},
"version": "FakeTSVersion",
"size": 2712
}

//// [/src/src-types/dogconfig.d.ts]
export interface DogConfig {
name: string;
}


//// [/src/src-types/dogconfig.js]
export {};


//// [/src/src-types/index.d.ts]
export * from './dogconfig.js';


//// [/src/src-types/index.js]
export * from './dogconfig.js';


//// [/src/src-types/tsconfig.tsbuildinfo]
{"program":{"fileNames":["../../lib/lib.es2022.full.d.ts","./dogconfig.ts","./index.ts"],"fileInfos":[{"version":"-7698705165-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }","affectsGlobalScope":true,"impliedFormat":1},{"version":"-5575793279-export interface DogConfig {\n name: string;\n}","signature":"-2632060142-export interface DogConfig {\r\n name: string;\r\n}\r\n","impliedFormat":99},{"version":"-6189272282-export * from './dogconfig.js';","signature":"-5608794531-export * from './dogconfig.js';\r\n","impliedFormat":99}],"options":{"composite":true,"declaration":true,"module":100},"fileIdsList":[[2]],"referencedMap":[[3,1]],"exportedModulesMap":[[3,1]],"semanticDiagnosticsPerFile":[1,2,3]},"version":"FakeTSVersion"}

//// [/src/src-types/tsconfig.tsbuildinfo.readable.baseline.txt]
{
"program": {
"fileNames": [
"../../lib/lib.es2022.full.d.ts",
"./dogconfig.ts",
"./index.ts"
],
"fileNamesList": [
[
"./dogconfig.ts"
]
],
"fileInfos": {
"../../lib/lib.es2022.full.d.ts": {
"version": "-7698705165-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }",
"signature": "-7698705165-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }",
"affectsGlobalScope": true,
"impliedFormat": 1
},
"./dogconfig.ts": {
"version": "-5575793279-export interface DogConfig {\n name: string;\n}",
"signature": "-2632060142-export interface DogConfig {\r\n name: string;\r\n}\r\n",
"impliedFormat": 99
},
"./index.ts": {
"version": "-6189272282-export * from './dogconfig.js';",
"signature": "-5608794531-export * from './dogconfig.js';\r\n",
"impliedFormat": 99
}
},
"options": {
"composite": true,
"declaration": true,
"module": 100
},
"referencedMap": {
"./index.ts": [
"./dogconfig.ts"
]
},
"exportedModulesMap": {
"./index.ts": [
"./dogconfig.ts"
]
},
"semanticDiagnosticsPerFile": [
"../../lib/lib.es2022.full.d.ts",
"./dogconfig.ts",
"./index.ts"
]
},
"version": "FakeTSVersion",
"size": 1038
}

exitCode:: ExitStatus.DiagnosticsPresent_OutputsSkipped


Loading