Pin all of the deps besides @types/node and @octokit/rest #53026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
DanielRosenwasser
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #53015 (review).
I religiously run
ncuand look for new major versions and send PRs to upgrade them if they won't break anything, so I don't see a problem removing as much"latest"as we can to make bisecting past bad bumps a little easier.I'm a little torn about
@types/nodeand@octokit/rest, though. The former is tricky because we often need to update that to deal with TS changes and such, and while I'd like to use node10 or even node12 as that's our minimum-ish, those aren't maintained, so the newest seems like the least bad. The latter is only there because of scripts in our repo used by random pipelines that arguably don't need to be in the repo and installed on everyone's machines, but that may go away if we transition more stuff to GHA.