Refactor workflows for new typescript-bot triggers #57409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
12 tasks
jakebailey
commented
Feb 28, 2024
weswigham
reviewed
Mar 2, 2024
| branch_name: | ||
| description: Release branch name to create | ||
| required: true | ||
| type: number |
There was a problem hiding this comment.
You're totally right, copy paste error, blah
| branch_name: | ||
| description: Release branch name to create | ||
| required: true | ||
| type: number |
| required: true | ||
| type: number |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes with microsoft/typescript-bot-test-triggerer#36.
Every action now uses a workflow dispatch (not a repo dispatch; the former is newer), along with new parameters for data sent by the bot. These options must always be defined for workflows the bot calls.
The composite action
.github/actions/post-workflow-result/action.ymlis used to share code between actions for updating the status comment and posting results. All of our workflows that trigger the bot use this, except the "repros" workflow, which has its own code for stuff (which I will just not touch for now).I'm not using a "reusable workflow" for this, as those jobs run in an entirely different unrelated context, whereas composite actions are just sorta jammed into an existing workflow (which is nice).
Most workflows don't change much, save for the cherry-pick action, which surprisingly was the only action that actually replied back.