Skip to content

Fix 'diagnosticMessages‘ Chinese translations #58129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cheezone
Copy link

@cheezone cheezone commented Apr 9, 2024

This PR fixes Chinese translations for the 'diagnosticMessages' file. It corrects translation errors to improve clarity and accuracy.

  1. initializer has been incorrectly translated as 初始化表杰式, which is grammatically incorrect in Chinese.
  2. The translation for accessing the property ['0'] incorrectly uses Chinese quotation marks [“0”], causing confusion for Chinese users.

Fix #58130

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 9, 2024
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, we do not have the means to verify that these changes are correct, both textually and that the files can still be loaded into the internal translation team's tooling.

@Jack-Works
Copy link
Contributor

At the moment, we do not have the means to verify that these changes are correct, both textually and that the files can still be loaded into the internal translation team's tooling.

Yes. It's correct, and the current shipping one is wrong. I have to say, that TypeScript's message translation quality is very low (so I never use it), it does not fit the language's conventions and uses strange nouns/verbs. I hope we can have community translation.

@sandersn sandersn self-assigned this Jun 12, 2024
@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 12, 2024
@sandersn
Copy link
Member

I agree that community translations are a good idea for something we don't have the budget for. Preferably user-selected. Since we don't have a way to accept these PRs right now, I think the right thing to do here is to close this PR for now and open an issue about community translation. Does that sound OK to you @cheezone ?

@sandersn sandersn closed this Apr 30, 2025
@github-project-automation github-project-automation bot moved this from Waiting on author to Done in PR Backlog Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect Chinese Translation for 'initializer' and Incorrect Use of Chinese Quotation Marks
5 participants