Check expression operand equivalence in isMatchingReference before computing property key equivalence #61608

RyanCavanaugh · 2025-04-22T22:05:59Z

Fixes #61606. Need PR results to see if this is worth it or not.

Update: Seems good?

…erty key equivalence Fixes microsoft#61606. Need PR results to see if this is worth it or not.

RyanCavanaugh · 2025-04-22T22:06:06Z

typescript-bot · 2025-04-22T22:06:11Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

Copilot

Pull Request Overview

This PR addresses bug #61606 by updating the check for element access expressions in the type checker. The key changes include:

Adding a new test case (tests/cases/compiler/circularRefFromClassMember.ts) to verify correct behavior.
Updating the corresponding baseline (tests/baselines/reference/circularRefFromClassMember.js).
Modifying the logic in src/compiler/checker.ts to first ensure that the operand expressions are equivalent before comparing property keys.

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File	Description
tests/cases/compiler/circularRefFromClassMember.ts	New test case to validate the fix for bug #61606.
tests/baselines/reference/circularRefFromClassMember.js	Updated baseline output consistent with the new test.
src/compiler/checker.ts	Revised element access check to verify operand equivalence prior to property key comparison.

Files not reviewed (2)

tests/baselines/reference/circularRefFromClassMember.symbols: Language not supported
tests/baselines/reference/circularRefFromClassMember.types: Language not supported

Comments suppressed due to low confidence (1)

src/compiler/checker.ts:27187

The new check ensures that the operands of the element accesses are equivalent before comparing property keys. Please verify that this ordering correctly handles all edge cases and add an inline comment explaining the rationale if necessary.

if (isAccessExpression(target) && isMatchingReference((source as AccessExpression).expression, target.expression)) {

typescript-bot · 2025-04-22T22:28:20Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-04-22T22:29:29Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/61608/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Timeout"

Otherwise...

Everything looks good!

typescript-bot · 2025-04-22T22:52:14Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,785k (± 1.02%)}	_{194,279k (± 0.91%)}	_~	_192,897k	_196,620k	_{p=0.810 n=6}
_{Parse Time}	_{1.31s (± 0.57%)}	_{1.30s (± 0.58%)}	_{-0.01s (- 1.02%)}	_1.29s	_1.31s	_{p=0.024 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.72s (± 0.18%)}	_{9.75s (± 0.46%)}	_~	_9.71s	_9.83s	_{p=0.244 n=6}
_{Emit Time}	_{2.74s (± 0.83%)}	_{2.73s (± 0.75%)}	_~	_2.70s	_2.75s	_{p=0.328 n=6}
_{Total Time}	_{14.50s (± 0.09%)}	_{14.51s (± 0.37%)}	_~	_14.46s	_14.60s	_{p=0.809 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,670	_948,670	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,947	_410,947	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,348k (± 0.01%)}	_{1,224,320k (± 0.00%)}	_~	_1,224,259k	_1,224,396k	_{p=0.689 n=6}
_{Parse Time}	_{6.66s (± 0.35%)}	_{6.63s (± 0.88%)}	_~	_6.54s	_6.68s	_{p=0.466 n=6}
_{Bind Time}	_{1.88s (± 0.64%)}	_{1.88s (± 0.55%)}	_~	_1.87s	_1.89s	_{p=0.337 n=6}
_{Check Time}	_{31.94s (± 0.33%)}	_{31.92s (± 0.49%)}	_~	_31.68s	_32.11s	_{p=1.000 n=6}
_{Emit Time}	_{15.24s (± 0.38%)}	_{15.30s (± 0.30%)}	_~	_15.24s	_15.37s	_{p=0.127 n=6}
_{Total Time}	_{55.72s (± 0.25%)}	_{55.73s (± 0.28%)}	_~	_55.53s	_55.98s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,361,522	_2,361,522	_~	_~	_~	_{p=1.000 n=6}
_Types	_868,648	_868,648	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,316,650k (± 0.00%)}	_{2,316,624k (± 0.00%)}	_~	_2,316,549k	_2,316,722k	_{p=0.688 n=6}
_{Parse Time}	_{8.73s (± 0.32%)}	_{8.75s (± 0.23%)}	_~	_8.72s	_8.78s	_{p=0.373 n=6}
_{Bind Time}	_{2.19s (± 0.63%)}	_{2.19s (± 0.45%)}	_~	_2.18s	_2.20s	_{p=0.933 n=6}
_{Check Time}	_{69.69s (± 0.45%)}	_{70.00s (± 0.46%)}	_~	_69.45s	_70.38s	_{p=0.109 n=6}
_{Emit Time}	_{0.30s (± 2.49%)}	_{0.30s (± 2.75%)}	_~	_0.29s	_0.31s	_{p=0.306 n=6}
_{Total Time}	_{80.92s (± 0.40%)}	_{81.23s (± 0.40%)}	_~	_80.67s	_81.63s	_{p=0.127 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,025	_1,228,025	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,258	_267,258	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,360,471k (± 0.03%)}	_{2,360,469k (± 0.02%)}	_~	_2,360,020k	_2,361,061k	_{p=1.000 n=6}
_{Parse Time}	_{5.20s (± 0.85%)}	_{5.21s (± 0.54%)}	_~	_5.16s	_5.24s	_{p=0.574 n=6}
_{Bind Time}	_{1.80s (± 0.45%)}	_{1.81s (± 0.76%)}	_~	_1.79s	_1.83s	_{p=0.865 n=6}
_{Check Time}	_{35.30s (± 0.27%)}	_{35.33s (± 0.24%)}	_~	_35.26s	_35.44s	_{p=0.810 n=6}
_{Emit Time}	_{3.00s (± 0.77%)}	_{3.01s (± 0.85%)}	_~	_2.99s	_3.06s	_{p=0.257 n=6}
_{Total Time}	_{45.30s (± 0.21%)}	_{45.37s (± 0.17%)}	_~	_45.27s	_45.46s	_{p=0.128 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,025	_1,228,025	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,258	_267,258	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,038,076k (± 9.78%)}	_{3,038,438k (± 9.78%)}	_~	_2,431,413k	_3,160,699k	_{p=0.575 n=6}
_{Parse Time}	_{6.93s (± 1.22%)}	_{7.02s (± 1.32%)}	_{+0.09s (+ 1.37%)}	_6.87s	_7.16s	_{p=0.045 n=6}
_{Bind Time}	_{2.16s (± 1.42%)}	_{2.15s (± 1.80%)}	_~	_2.09s	_2.19s	_{p=0.574 n=6}
_{Check Time}	_{42.86s (± 0.59%)}	_{42.80s (± 0.36%)}	_~	_42.60s	_42.95s	_{p=0.575 n=6}
_{Emit Time}	_{3.55s (± 4.63%)}	_{3.48s (± 2.46%)}	_~	_3.38s	_3.59s	_{p=0.575 n=6}
_{Total Time}	_{55.51s (± 0.33%)}	_{55.46s (± 0.37%)}	_~	_55.07s	_55.67s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,403	_263,403	_~	_~	_~	_{p=1.000 n=6}
_Types	_107,094	_107,094	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,709k (± 0.02%)}	_{441,744k (± 0.01%)}	_~	_441,665k	_441,786k	_{p=0.230 n=6}
_{Parse Time}	_{3.55s (± 0.49%)}	_{3.56s (± 0.95%)}	_~	_3.52s	_3.61s	_{p=0.568 n=6}
_{Bind Time}	_{1.33s (± 0.88%)}	_{1.32s (± 1.01%)}	_~	_1.30s	_1.34s	_{p=0.117 n=6}
_{Check Time}	_{19.00s (± 0.40%)}	_{19.01s (± 0.37%)}	_~	_18.91s	_19.09s	_{p=0.748 n=6}
_{Emit Time}	_{1.53s (± 0.69%)}	_{1.54s (± 0.89%)}	_{+0.02s (+ 1.31%)}	_1.53s	_1.56s	_{p=0.033 n=6}
_{Total Time}	_{25.41s (± 0.20%)}	_{25.45s (± 0.22%)}	_~	_25.37s	_25.53s	_{p=0.336 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,981	_225,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,356	_94,356	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,296k (± 0.01%)}	_{371,363k (± 0.03%)}	_~	_371,252k	_371,600k	_{p=0.378 n=6}
_{Parse Time}	_{2.90s (± 0.22%)}	_{2.91s (± 0.99%)}	_~	_2.86s	_2.94s	_{p=0.411 n=6}
_{Bind Time}	_{1.61s (± 1.46%)}	_{1.61s (± 0.88%)}	_~	_1.59s	_1.63s	_{p=0.807 n=6}
_{Check Time}	_{16.52s (± 0.42%)}	_{16.49s (± 0.28%)}	_~	_16.43s	_16.57s	_{p=0.627 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{21.03s (± 0.33%)}	_{21.01s (± 0.16%)}	_~	_20.97s	_21.05s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₄	₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,367,726	_3,367,726	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,141,078	_1,141,078	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,425,118k (± 0.01%)}	_{3,425,154k (± 0.01%)}	_~	_3,424,836k	_3,425,355k	_{p=0.575 n=6}
_{Parse Time}	_{14.58s (± 0.28%)}	_{14.59s (± 0.57%)}	_~	_14.53s	_14.75s	_{p=1.000 n=6}
_{Bind Time}	_{4.68s (± 0.53%)}	_{4.67s (± 0.30%)}	_~	_4.65s	_4.68s	_{p=0.291 n=6}
_{Check Time}	_{93.06s (± 3.71%)}	_{91.20s (± 0.16%)}	_~	_90.99s	_91.34s	_{p=0.378 n=6}
_{Emit Time}	_{29.69s (± 2.25%)}	_{29.44s (± 0.52%)}	_~	_29.32s	_29.73s	_{p=1.000 n=6}
_{Total Time}	_{142.00s (± 2.88%)}	_{139.90s (± 0.13%)}	_~	_139.60s	_140.15s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_316,147	_316,147	_~	_~	_~	_{p=1.000 n=6}
_Types	_140,126	_140,126	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{470,923k (± 0.02%)}	_{470,836k (± 0.04%)}	_~	_470,538k	_471,017k	_{p=0.298 n=6}
_{Parse Time}	_{5.17s (± 0.56%)}	_{5.16s (± 0.82%)}	_~	_5.11s	_5.21s	_{p=0.572 n=6}
_{Bind Time}	_{2.24s (± 0.87%)}	_{2.26s (± 1.17%)}	_~	_2.21s	_2.28s	_{p=0.124 n=6}
_{Check Time}	_{25.81s (± 0.38%)}	_{26.06s (± 2.07%)}	_~	_25.70s	_27.14s	_{p=0.378 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{33.22s (± 0.30%)}	_{33.48s (± 1.61%)}	_~	_33.08s	_34.55s	_{p=0.378 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_570,517	_570,517	_~	_~	_~	_{p=1.000 n=6}
_Types	_191,417	_191,417	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{500,781k (± 0.05%)}	_{500,818k (± 0.03%)}	_~	_500,602k	_501,005k	_{p=1.000 n=6}
_{Parse Time}	_{4.32s (± 0.60%)}	_{4.32s (± 0.32%)}	_~	_4.30s	_4.33s	_{p=0.625 n=6}
_{Bind Time}	_{1.53s (± 0.79%)}	_{1.54s (± 0.68%)}	_~	_1.52s	_1.55s	_{p=0.868 n=6}
_{Check Time}	_{25.38s (± 2.91%)}	_{25.17s (± 1.97%)}	_~	_24.73s	_26.04s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{31.24s (± 2.31%)}	_{31.02s (± 1.57%)}	_~	_30.56s	_31.87s	_{p=0.630 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-04-22T23:38:21Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61608/merge:

Everything looks good!

Check target equivalence in isMatchingReference before computing prop…

366d3f4

…erty key equivalence Fixes microsoft#61606. Need PR results to see if this is worth it or not.

Copilot AI review requested due to automatic review settings April 22, 2025 22:06

github-project-automation bot added this to PR Backlog Apr 22, 2025

github-project-automation bot moved this to Not started in PR Backlog Apr 22, 2025

typescript-bot assigned RyanCavanaugh Apr 22, 2025

typescript-bot added the Author: Team label Apr 22, 2025

typescript-bot added For Backlog Bug PRs that fix a backlog bug labels Apr 22, 2025

Copilot AI reviewed Apr 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check expression operand equivalence in isMatchingReference before computing property key equivalence #61608

Check expression operand equivalence in isMatchingReference before computing property key equivalence #61608

RyanCavanaugh commented Apr 22, 2025 •

edited

Loading

RyanCavanaugh commented Apr 22, 2025

typescript-bot commented Apr 22, 2025 •

edited

Loading

Copilot AI left a comment

typescript-bot commented Apr 22, 2025

typescript-bot commented Apr 22, 2025

typescript-bot commented Apr 22, 2025

tsc

typescript-bot commented Apr 22, 2025

Check expression operand equivalence in isMatchingReference before computing property key equivalence #61608

Are you sure you want to change the base?

Check expression operand equivalence in isMatchingReference before computing property key equivalence #61608

Conversation

RyanCavanaugh commented Apr 22, 2025 • edited Loading

RyanCavanaugh commented Apr 22, 2025

typescript-bot commented Apr 22, 2025 • edited Loading

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

typescript-bot commented Apr 22, 2025

typescript-bot commented Apr 22, 2025

typescript-bot commented Apr 22, 2025

tsc

typescript-bot commented Apr 22, 2025

RyanCavanaugh commented Apr 22, 2025 •

edited

Loading

typescript-bot commented Apr 22, 2025 •

edited

Loading