Add some symlink support #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
commented
Feb 25, 2025
andrewbranch
approved these changes
Feb 25, 2025
jakebailey
commented
Feb 25, 2025
| if entryType&fs.ModeIrregular != 0 && vfs.Realpath != nil { | ||
| // Could be a Windows junction. Try Realpath. | ||
| fullPath := path + "/" + entry.Name() | ||
| if realpath := vfs.Realpath(fullPath); fullPath != realpath { |
There was a problem hiding this comment.
Note that this is not the fastest way to do this at all; but the code to do this correctly on Windows is pretty funky (see the intermediate state in #186, which I will bring back). Something I want to address in a follow-up PR.
There was a problem hiding this comment.
For reference: 8998046
There was a problem hiding this comment.
(realpath however, is very very reliable!)
jakebailey
commented
Feb 25, 2025
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unbreaks
@typesauto loading when@types/*are symlinks to dirs, which is what pnpm does.I think this probably completes symlink support outside of testing;
getAccessibleFileSystemEntriesappears to be the only thing that actually checked in the old codebase.I am not 100% happy with the callback-y nature of this, but I can't yet think of a better way to handle this code without repetition.