-
Notifications
You must be signed in to change notification settings - Fork 641
Check for unused baselines in CI, remove unused baselines #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to clean up the repository by removing unused baseline reference files and adding a new CI job to manage baselines automatically.
- Removed obsolete baseline files from submodule directories.
- Added a dedicated CI job in ci.yml to remove, accept, and check baselines, including the uploading of a patch artifact for any baseline differences.
Reviewed Changes
Copilot reviewed 13 out of 29 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
testdata/baselines/reference/submodule/conformance/typeOnlyMerge2.js | Removed unused conformance baseline file. |
testdata/baselines/reference/submodule/compiler/filesEmittingIntoSameOutput.js | Removed unused compiler baseline file. |
testdata/baselines/reference/submodule/compiler/fileReferencesWithNoExtensions.js | Removed unused baseline file for file references. |
.github/workflows/ci.yml | Added a new CI job to handle baseline removal, acceptance, and checking. |
Files not reviewed (16)
- testdata/baselines/reference/submodule/compiler/fileReferencesWithNoExtensions.js.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/fileReferencesWithNoExtensions.symbols: Language not supported
- testdata/baselines/reference/submodule/compiler/fileReferencesWithNoExtensions.types: Language not supported
- testdata/baselines/reference/submodule/compiler/filesEmittingIntoSameOutput.js.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/filesEmittingIntoSameOutput.symbols: Language not supported
- testdata/baselines/reference/submodule/compiler/filesEmittingIntoSameOutput.types: Language not supported
- testdata/baselines/reference/submodule/compiler/jsFileCompilationWithoutJsExtensions.errors.txt.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/es2022SharedMemory.errors.txt: Language not supported
- testdata/baselines/reference/submodule/conformance/es2022SharedMemory.errors.txt.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/es2022SharedMemory.symbols: Language not supported
- testdata/baselines/reference/submodule/conformance/es2022SharedMemory.symbols.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/es2022SharedMemory.types: Language not supported
- testdata/baselines/reference/submodule/conformance/es2022SharedMemory.types.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/typeOnlyMerge2.errors.txt: Language not supported
- testdata/baselines/reference/submodule/conformance/typeOnlyMerge2.js.diff: Language not supported
- testdata/baselines/reference/submodule/conformance/typeOnlyMerge2.symbols: Language not supported
jakebailey
commented
Mar 31, 2025
andrewbranch
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.