Skip to content

Check for unused baselines in CI, remove unused baselines #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2025

Conversation

jakebailey
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings March 31, 2025 16:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to clean up the repository by removing unused baseline reference files and adding a new CI job to manage baselines automatically.

  • Removed obsolete baseline files from submodule directories.
  • Added a dedicated CI job in ci.yml to remove, accept, and check baselines, including the uploading of a patch artifact for any baseline differences.

Reviewed Changes

Copilot reviewed 13 out of 29 changed files in this pull request and generated 1 comment.

File Description
testdata/baselines/reference/submodule/conformance/typeOnlyMerge2.js Removed unused conformance baseline file.
testdata/baselines/reference/submodule/compiler/filesEmittingIntoSameOutput.js Removed unused compiler baseline file.
testdata/baselines/reference/submodule/compiler/fileReferencesWithNoExtensions.js Removed unused baseline file for file references.
.github/workflows/ci.yml Added a new CI job to handle baseline removal, acceptance, and checking.
Files not reviewed (16)
  • testdata/baselines/reference/submodule/compiler/fileReferencesWithNoExtensions.js.diff: Language not supported
  • testdata/baselines/reference/submodule/compiler/fileReferencesWithNoExtensions.symbols: Language not supported
  • testdata/baselines/reference/submodule/compiler/fileReferencesWithNoExtensions.types: Language not supported
  • testdata/baselines/reference/submodule/compiler/filesEmittingIntoSameOutput.js.diff: Language not supported
  • testdata/baselines/reference/submodule/compiler/filesEmittingIntoSameOutput.symbols: Language not supported
  • testdata/baselines/reference/submodule/compiler/filesEmittingIntoSameOutput.types: Language not supported
  • testdata/baselines/reference/submodule/compiler/jsFileCompilationWithoutJsExtensions.errors.txt.diff: Language not supported
  • testdata/baselines/reference/submodule/conformance/es2022SharedMemory.errors.txt: Language not supported
  • testdata/baselines/reference/submodule/conformance/es2022SharedMemory.errors.txt.diff: Language not supported
  • testdata/baselines/reference/submodule/conformance/es2022SharedMemory.symbols: Language not supported
  • testdata/baselines/reference/submodule/conformance/es2022SharedMemory.symbols.diff: Language not supported
  • testdata/baselines/reference/submodule/conformance/es2022SharedMemory.types: Language not supported
  • testdata/baselines/reference/submodule/conformance/es2022SharedMemory.types.diff: Language not supported
  • testdata/baselines/reference/submodule/conformance/typeOnlyMerge2.errors.txt: Language not supported
  • testdata/baselines/reference/submodule/conformance/typeOnlyMerge2.js.diff: Language not supported
  • testdata/baselines/reference/submodule/conformance/typeOnlyMerge2.symbols: Language not supported

@jakebailey jakebailey enabled auto-merge March 31, 2025 20:57
@jakebailey jakebailey added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit 7a8ec61 Mar 31, 2025
23 checks passed
@jakebailey jakebailey deleted the jabaile/remove-unused-baselines branch March 31, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants