Skip to content

Ignore baseline diffs that use unsupported options #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andrewbranch
Copy link
Member

No description provided.

@andrewbranch andrewbranch requested review from Copilot and jakebailey and removed request for Copilot March 31, 2025 23:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the diagnostic verification logic to ignore baseline diffs when unsupported options are used. The changes include:

  • Using a new helper function, containsUnsupportedOptions(), to determine whether unsupported options exist.
  • Modifying the IsSubmoduleAccepted flag based on the new function.
  • Introducing additional checks for module kinds, BaseUrl, and RootDirs in the new helper function.
Comments suppressed due to low confidence (2)

internal/testrunner/compiler_runner.go:438

  • Ensure that unit tests cover all branches of the containsUnsupportedOptions function to validate its behavior across various supported and unsupported configuration scenarios.
func (c *compilerTest) containsUnsupportedOptions() bool {

internal/testrunner/compiler_runner.go:449

  • Verify whether checking only for nil is sufficient for c.options.RootDirs, or if an explicit check for an empty slice is required to accurately capture unsupported configurations.
if c.options.RootDirs != nil {

@andrewbranch andrewbranch enabled auto-merge March 31, 2025 23:33
@andrewbranch andrewbranch added this pull request to the merge queue Apr 1, 2025
Merged via the queue into microsoft:main with commit 0ca5839 Apr 1, 2025
23 checks passed
andrewbranch added a commit to andrewbranch/typescript-go that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants