Fixed: [bug/lsp]panic: vfs: path is not absolute #671

[gabrielluizsf]

@jakebailey
@gabritto
@andrewbranch

Old PR

[jakebailey]

This really needs some sort of test. Nobody's said how this problem surfaces.

[jakebailey]

Most of the changes in this PR are unrelated to the actual fix, which I believe is just basePath being modified. Can you please undo everything that is unrelated?

I will still say like last time that I don't think this is the right fix. The original getFileNamesFromConfigSpecs code does not do this; it only normalizes the path. If there's a bad path being passed into this function, the problem must be somewhere else.

[gabrielluizsf]

Most of the changes in this PR are unrelated to the actual fix, which I believe is just basePath being modified. Can you please undo everything that is unrelated?

I will still say like last time that I don't think this is the right fix. The original getFileNamesFromConfigSpecs code does not do this; it only normalizes the path. If there's a bad path being passed into this function, the problem must be somewhere else.

Most of the changes in this PR are unrelated to the actual fix, which I believe is just basePath being modified. Can you please undo everything that is unrelated?

I will still say like last time that I don't think this is the right fix. The original getFileNamesFromConfigSpecs code does not do this; it only normalizes the path. If there's a bad path being passed into this function, the problem must be somewhere else.

Thank you for your feedback. I understand your concerns regarding the scope of the changes. I'll revert the unrelated modifications to keep the PR focused on the actual fix.

Regarding the approach, I see your point about getFileNamesFromConfigSpecs only normalizing the path. I'll take a closer look to identify where the incorrect path is being introduced and determine if the issue originates elsewhere. Let me know if you have any additional insights.