More fixes to type checking #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
requested review from
Copilot and
jakebailey
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 138 out of 147 changed files in this pull request and generated no comments.
Files not reviewed (9)
- testdata/baselines/reference/submodule/compiler/expressionWithJSDocTypeArguments.errors.txt.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/expressionWithJSDocTypeArguments.js.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/expressionWithJSDocTypeArguments.types: Language not supported
- testdata/baselines/reference/submodule/compiler/expressionWithJSDocTypeArguments.types.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/jsxImportSourceNonPragmaComment.errors.txt.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/jsxIntrinsicElementsTypeArgumentErrors.errors.txt.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/jsxNamespacePrefixInName.symbols: Language not supported
- testdata/baselines/reference/submodule/compiler/jsxNamespacePrefixInName.symbols.diff: Language not supported
- testdata/baselines/reference/submodule/compiler/jsxNamespacePrefixInNameReact.symbols: Language not supported
Comments suppressed due to low confidence (3)
internal/scanner/scanner.go:1014
- The removal of the error reporting call for unterminated regex literals might result in silent failures. Consider either reintroducing the error logging or providing an alternative mechanism to ensure that unterminated regular expressions are appropriately reported.
s.error(diagnostics.Unterminated_regular_expression_literal)
internal/binder/binder.go:327
- [nitpick] Ensure that the updated condition handling JSX namespaced names covers all edge cases. Consider adding unit tests to validate behavior for namespaced JSX identifiers.
if ast.IsPropertyNameLiteral(name) || ast.IsJsxNamespacedName(name) {
internal/checker/checker.go:6627
- [nitpick] Double-check that excluding type parameter declarations from unused local diagnostics does not inadvertently hide genuine unused variables. Verify that this change aligns with the overall intended behavior of the diagnostic checks.
if !ast.IsTypeParameterDeclaration(declaration) && !ast.IsAmbientModule(declaration) {
jakebailey
approved these changes
Apr 16, 2025
| @@ -1266,23 +1265,3 @@ func (c *Checker) getJsxNamespaceContainerForImplicitImport(location *ast.Node) | |||
| func (c *Checker) getJSXRuntimeImportSpecifier(file *ast.SourceFile) (moduleReference string, specifier *ast.Node) { | |||
| return c.program.GetJSXRuntimeImportSpecifier(file.Path()) | |||
| } | |||
|
|
|||
| func getPragmaFromSourceFile(file *ast.SourceFile, name string) *ast.Pragma { | |||
There was a problem hiding this comment.
Shoot, I must have forgotten to delete this.
| @@ -43,79 +17,27 @@ expressionWithJSDocTypeArguments.ts(27,39): error TS1109: Expression expected. | |||
| ~ | |||
| !!! error TS1110: Type expected. | |||
| const HuhFoo = foo<string?>; | |||
There was a problem hiding this comment.
I thought this was an intentional difference? https://github.com/microsoft/typescript-go/blob/main/CHANGES.md#parser:~:text=No%20postfix%20T%3F%20and%20T!%20types. notes that as a removed thing.
There was a problem hiding this comment.
Hadn't noticed that we were going to outlaw the postfix forms. Let's discuss and if we still feel that way we can back it out. Or we could continue to parse them (for better error recovery) and then always issue a grammar error.
Comment on lines
32
to
+33
| ->a:attr : Symbol(a:attr, Decl(jsxNamespacePrefixInName.tsx, 18, 22)) | ||
| +>a:attr : Symbol("�missing", Decl(jsxNamespacePrefixInName.tsx, 18, 22)) | ||
| +>a:attr : Symbol("a:attr", Decl(jsxNamespacePrefixInName.tsx, 18, 22)) |
There was a problem hiding this comment.
Interesting, I wonder where the symbol printing differs for this now, since it's just quoting left.
There was a problem hiding this comment.
It comes from this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.