Improve logic for choosing value/type meanings in quick info

[ahejlsberg]

This PR fixes logic for choosing value/type meanings in quick info that wasn't quite working correctly. We now show the right meaning when hovering on each of the identifiers in this code:

enum E {
    A = 1,
    B = "hello",
    C = Math.sqrt(2)
}

interface Thing {
    bar: number
}
declare const Thing: () => Thing

let t1: typeof Thing = Thing
let t2: Thing = Thing()

Thing().bar

declare function strange<T>(T: T): T;

[Copilot]

Pull Request Overview

This PR improves the logic for choosing value/type meanings in quick info so that the correct meanings are displayed when hovering over identifiers.

• Updated the condition to check if the node is part of a type node or a type declaration name.
• Changed the flag clearing to remove variable and function flags when in a type context.

[Copilot]

[nitpick] The updated condition clarifies when a node is in a type context, but consider adding a comment explaining why 'isTypeDeclarationName' is checked here to improve code clarity.

Suggested change

	// If the symbol has a type meaning and we're in a type context, remove value-only meanings
	// If the symbol has a type meaning and we're in a type context, remove value-only meanings.
	// The `isTypeDeclarationName` function checks if the node represents a name in a type declaration,
	// ensuring that type-related flags are preserved while excluding value-only flags.

[jakebailey]

These nitpick comments are getting awful

[ahejlsberg]

Indeed!

[Copilot]

[nitpick] The change from clearing all value flags to only clearing variable and function flags may be intentional; adding a clarifying comment on why other value flags are preserved would enhance maintainability.

Suggested change

	// If the symbol has a type meaning and we're in a type context, remove value-only meanings
	// If the symbol has a type meaning and we're in a type context, remove value-only meanings
	// Specifically, clear the Variable and Function flags to avoid treating the symbol as a value.
	// Other value flags are preserved intentionally to retain their specific meanings in this context.

[jakebailey]

IIRC Strada has a lot of logic for this but this seems reasonable