Skip to content

Could not auto close unsaved editor when delete #347

Open
@xqzlgy2

Description

@xqzlgy2

The newly added "delete" feature #343 works well when we try to delete unchanged files. However, if we try to delete file with unsaved changes, the editor will not be closed and will looks like below:

image

This is not consistent with native file explorer's behavior and may also cause user lose their changes before deletion. However, this part is hard to fix due to API limitation, since many needed functions are encapsulated within the implementation of VS Code built-in commands. If microsoft/vscode#107566 could be solved, we can fix this problem easily.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingupstream

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions