Skip to content

Test #351 to ensure that CompletionItem data is preserved #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

Test #351 to ensure that CompletionItem data is preserved #352

merged 1 commit into from
May 22, 2018

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented May 22, 2018

I've added tests to ensure that if a CompletionItem has data === 0, data === false, or data === "", it will be preserved across a textDocument/completionItem and a completionItem/resolve request.

@dbaeumer
Copy link
Member

Thanks a lot.

@dbaeumer dbaeumer merged commit 0e1fe5e into microsoft:master May 22, 2018
@rcjsuen rcjsuen deleted the empty-data branch May 22, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcjsuen @dbaeumer