-
Notifications
You must be signed in to change notification settings - Fork 608
Include PR template in PR description if there is just one commit #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include PR template in PR description if there is just one commit #2846
Conversation
} | ||
} | ||
|
||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't too sure how to handle the case where this.compareBranch == null
. Advice appreciated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0 seems reasonable here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the upstream
is undefined we can use the git API to get the number of changes. I have added that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
} | ||
} | ||
|
||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0 seems reasonable here.
} | ||
} | ||
|
||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the upstream
is undefined we can use the git API to get the number of changes. I have added that.
For what it's worth, this doesn't seem to be working for me in v0.29.3. apollographql/apollo-server#5639 is an example of a single-commit PR I just make where I had to put the commit message in the description manually. |
We have not yet made our August Milestone release yet (more info on the timing of our releases: https://github.com/microsoft/vscode-pull-request-github/wiki#4-when-will-the-next-release-occur) |
Ah, OK — I thought that v0.29.3 was after this fix merged and that's what my VSCode is running though. |
Fixes #2540