Skip to content

When using a branch name as a PR title, ensure the first letter is capitalized #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2021
Merged

When using a branch name as a PR title, ensure the first letter is capitalized #2848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dbeb74
When using a branch name as a PR title, ensure the first letter is ca…
joshuaobrien Jul 19, 2021
13d8f32
Fix some nits
alexr00 Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/github/createPRViewProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,10 @@ export class CreatePullRequestViewProvider extends WebviewViewBase implements vs
}

if (useBranchName) {
return this.compareBranch?.name ?? '';
const name = this.compareBranch?.name;
return name
? `${name.charAt(0).toUpperCase()}${name.slice(1)}`
: '';
} else {
return this.compareBranch?.name
? titleAndBodyFrom(await this._folderRepositoryManager.getTipCommitMessage(this.compareBranch.name))
Expand Down