Display linked issue(s) from the PR Overview #5824 #6835
Conversation
|
the closing issues of a PR are retireved succesfully as props to the sidebar component, what's missing is
|
| @@ -632,6 +632,14 @@ export interface PullRequest extends Issue { | |||
| viewerCanDisableAutoMerge: boolean; | |||
| isDraft?: boolean; | |||
| suggestedReviewers: SuggestedReviewerResponse[]; | |||
| closingIssuesReferences?: { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
any comments on this so far ? @alexr00 |
|
I'll try to take a look on Friday. We're doing our release prep week now (endgame). |
There was a problem hiding this comment.
Thanks for the PR @mohamedamara1! I made a few small changes, and I have a few comments, as well as feedback on the UI itself:
| <div className="section-title">Linked Issues</div> | ||
| </div> | ||
| {closingIssues.length > 0 ? ( | ||
| <div className="p-2"> |
There was a problem hiding this comment.
Please use a class name that is consistent with the class naming scheme in the file.
| @@ -96,6 +96,7 @@ export interface PullRequest extends Issue { | |||
| lastReviewType?: ReviewType; | |||
| revertable?: boolean; | |||
| busy?: boolean; | |||
| closingIssues: Pick<Issue, 'title' | 'number' | 'state'>[]; | |||
There was a problem hiding this comment.
Pick<Issue, 'title' | 'number' | 'state'> is used in more than one place, can you refactor it into an IssueReference type in this file?
|
|
||
| switch (normalizedState) { | ||
| case 'open': | ||
| return settingsIcon; |
Replacement of #5825