-
Notifications
You must be signed in to change notification settings - Fork 8
Adding menu items #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding menu items #310
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { MarkdownString, window } from 'vscode'; | ||
import { PythonProject, PythonProjectCreator, PythonProjectCreatorOptions } from '../../api'; | ||
import { PythonProjectManager } from '../../internal.api'; | ||
// import { runInBackground } from '../execution/runInBackground'; | ||
|
||
export class NewPackageProject implements PythonProjectCreator { | ||
public readonly name = 'newPackage'; | ||
public readonly displayName = 'Python Package'; | ||
eleanorjboyd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public readonly description = 'Create a new Python package project'; | ||
eleanorjboyd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public readonly tooltip = new MarkdownString('Create a new Python package with proper structure'); | ||
eleanorjboyd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
constructor(private readonly pm: PythonProjectManager) {} | ||
Check failure on line 12 in src/features/creators/newPackageProject.ts
|
||
|
||
async create(_options?: PythonProjectCreatorOptions): Promise<PythonProject | undefined> { | ||
// show notification that the pkg creation was selected than return undefined | ||
window.showInformationMessage('Creating a new Python package project...'); | ||
eleanorjboyd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return undefined; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { MarkdownString, window } from 'vscode'; | ||
import { PythonProject, PythonProjectCreator, PythonProjectCreatorOptions } from '../../api'; | ||
import { PythonProjectManager } from '../../internal.api'; | ||
|
||
export class NewScriptProject implements PythonProjectCreator { | ||
public readonly name = 'newScript'; | ||
public readonly displayName = 'Script'; | ||
public readonly description = 'Create a new Python script project'; | ||
eleanorjboyd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public readonly tooltip = new MarkdownString('Create a new Python script with basic structure'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similarly here, should we be presenting this as the base "Python project" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so do you think I should just say "project" for the display name then too? Once we get pep 723 then we will look to separate them since the requirements will be done differently? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also do we care these are the same wording:
|
||
|
||
constructor(private readonly pm: PythonProjectManager) {} | ||
Check failure on line 11 in src/features/creators/newScriptProject.ts
|
||
|
||
async create(_options?: PythonProjectCreatorOptions): Promise<PythonProject | undefined> { | ||
// show notification that the script creation was selected than return undefined | ||
window.showInformationMessage('Creating a new Python script project...'); | ||
eleanorjboyd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return undefined; | ||
} | ||
} |
Uh oh!
There was an error while loading. Please reload this page.