Align in-editor peek views (test, problems, references, etc.) UX

[miguelsolorio]

Summary

This issue aims to capture the consolidation of the test peek view + problems "go to problem" view. The problems view has UI to view the context of the failures, similar to a peek definition, while the problems view has limited UI and causes users to navigate from the error to the problems panel to see the next set of problems/warnings.

Test failures

Problems view

Concepts

One idea is to combine the test UI with problems:

• Add toolbar options for navigating and toggling the side view inside of the peek view
• Provide inline actions for problems where relevant (quick fix)
• Update colors to add visual refresh to peek view

cc @connor4312 @sandy081

[connor4312]

I like the visual refresh. In previous discussions in my 1:1's with Kai I was an advocate for the combination (I think "alignment" might be a better word, not sure how much reuse there would be on a code level) to bring a tree or list view into the problems peek. I like having everything in one place and not have to look in the sidebar or panel when I'm going through issues.

[miguelsolorio]

Some feedback we saw in our ux sync today:

• The arrows should only appear when the side panel is not visible as that is primary way to navigate
• We should align this work with our peek views as well (references)
• Would expect for these to work similar to references where you can navigate to other tests
• We should persist the side panel per each area (references, test, problems, etc.)

And below is an example of aligning the UI in the peek view with this:

[sandy081]

So we are trying to bring the items explorer into the peek view that can be toggle-able? If so, Problem peek will have all problems from the file. How about test failure peek? Does it contain all test failures or history of test failures?

[miguelsolorio]

Yes, the concept is that all peek views have the same building blocks (navigation, panel, etc.). For problems, showing all errors and warnings for what we show in the panel is what I would expect. In tests, it shows the history of the tests. So they are slightly different but still similar and I think that's ok. References shows all files where there are references to those items, so that's also slightly different. But the main blocks remain the same in terms of layout.

[byehack]

• support up/down key on peek view panel focused.

[miguelsolorio]

@byehack can you elaborate? up/down keys already work on the peek view panel

[byehack]

@byehack can you elaborate? up/down keys already work on the peek view panel

Rec.0029.mp4

stable v1.59.0