Trivial sketch won't compile using Arduino 1.8.13

[nholthaus]

This library worked mostly fine for me in Arduino 1.8.12, but in 1.8.13 the following trivial sketch won't compile. My intuition is that it's an include-order dependency issue.

#include <ArduinoSTL.h>

void setup() {
  // put your setup code here, to run once:
}

void loop() {
  // put your main code here, to run repeatedly:
}

with the following errors:

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\del_opvs.cpp:25:53: error: 'std::size_t' has not been declared

_UCXXEXPORT void operator delete[](void * ptr, std::size_t) throw(){

                                                 ^~~~~~

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\del_opnt.cpp:25:56: error: 'nothrow_t' in namespace 'std' does not name a type

_UCXXEXPORT void operator delete(void* ptr, const std::nothrow_t& ) throw() {

                                                    ^~~~~~~~~

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\del_ops.cpp:25:50: error: 'std::size_t' has not been declared

_UCXXEXPORT void operator delete(void* ptr, std::size_t) throw(){

                                              ^~~~~~

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\del_opvnt.cpp:25:58: error: 'nothrow_t' in namespace 'std' does not name a type

_UCXXEXPORT void operator delete[](void* ptr, const std::nothrow_t& ) throw(){

                                                      ^~~~~~~~~

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\new_opnt.cpp:25:37: error: declaration of 'operator new' as non-function

_UCXXEXPORT void* operator new(std::size_t numBytes, const std::nothrow_t& ) throw(){

                                 ^~~~~~

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\new_opnt.cpp:25:37: error: 'size_t' is not a member of 'std'

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\new_opnt.cpp:25:37: note: suggested alternative:

In file included from c:\users\nholt\appdata\local\arduino15\packages\arduino\tools\avr-gcc\7.3.0-atmel3.6.1-arduino7\avr\include\stdlib.h:48:0,

             from C:\Users\NHolt\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.3\cores\arduino/new.h:22,

             from C:\Users\NHolt\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.3\cores\arduino/new:5,

             from E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\new_opnt.cpp:20:

c:\users\nholt\appdata\local\arduino15\packages\arduino\tools\avr-gcc\7.3.0-atmel3.6.1-arduino7\lib\gcc\avr\7.3.0\include\stddef.h:216:23: note: 'size_t'

typedef SIZE_TYPE size_t;

                   ^~~~~~

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\new_opnt.cpp:25:54: error: expected primary-expression before 'const'

_UCXXEXPORT void* operator new(std::size_t numBytes, const std::nothrow_t& ) throw(){

                                                  ^~~~~

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\new_handler.cpp:22:12: error: 'nothrow_t' in namespace 'std' does not name a type

const std::nothrow_t std::nothrow = { };

        ^~~~~~~~~

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\new_handler.cpp:25:6: error: 'new_handler' in namespace 'std' does not name a type

std::new_handler __new_handler;

  ^~~~~~~~~~~

E:\Users\NHolt\Documents\Arduino\libraries\ArduinoSTL-master\src\new_handler.cpp:27:1: error: '_UCXXEXPORT' does not name a type

_UCXXEXPORT std::new_handler std::set_new_handler(std::new_handler new_p) throw(){

^~~~~~~~~~~

exit status 1

[nholthaus]

The problem appears to be that if you have other IDEs installed (e.g. Visual Studio), the include search paths find the platforms std library implementation headers. Switching the include statements from <> to "" forces the use of the local std library implementation, which is what you want here. I'll submit a patch.

[roelschroeven]

I think there's another reason: new versions of the AVR core have a header file 'new' that conflicts with the one from ArduinoSTL (arduino/ArduinoCore-avr@d1ae194). If anyone opens the Arduino IDE, goes to Tools -> Board -> Board manager and updates the Arduino AVR Boards to version 1.8.3, he/she will likely have the same problem.

The result is the same, so nbolthaus' pull request should solve it all the same.

Workaround in the meantime: downgrade Arduino AVR Boards to 1.8.2.

[mike-matera]

Hi. I'll take a look at fixing this. I haven't used Arduino in a while.

[Dantali0n]

I can confirm I am experiencing the same problems as @roelschroeven using IDE 1.8.3 for AVR devices

[matthijskooijman]

This is indeed a problem triggered by Arduino adding a <new> header that is not actually complete. It already offered it as new.h and it seemed like a good idea to offer it as <new> as well, but I hadn't considered this problem when I reviewed that PR :-)

I believe the proper solution on the Arduino end is to make sure that it implements the <new> header completely and in a standards-compliant way, I believe this should make ArduinoSTL work again as well. I'm planning to provide a PR to Arduino for this, see arduino/ArduinoCore-avr#287 for some additional discussion of that.

[matthijskooijman]

I created a PR for the Arduino AVR core, testing is welcome: arduino/ArduinoCore-avr#361

That almost solves this issue, the one remaining problem I saw is that src/new_handler.cpp in ArduinoSTL only includes <new>, and assumes that that makes _UCXXEXPORT available, However, when the Arduino version of <new> is used, this assumption is incorrect. For other cpp files that include new this is not an issue because they also include other files.

I don't think this can be fixed on the Arduino side, but I can see two ways to fix this in ArduinoSTL:

1. Use #include "new", as suggested before (but maybe not for all includes, just for new?)
2. Explicitly add #include <basic_definitions> to new_handler.cpp to make _UCXXEXPORT available. I tried this, and that works. This is still a workaround, since it is really only needed because we know that new will be provided by Arduino rather than ArduinoSTL.

I'm not sure which would be the best solution, though.

[matthijskooijman]

The PR in the AVR core is merged, so that leaves just the second issue I noted above.

[Dantali0n]

The PR in the AVR core is merged, so that leaves just the second issue I noted above.

Thank you for your efforts at making ArduinoSTL work with AVR boards 1.8.3

[matthijskooijman]

Hm, I just noticed a new problem:

new.cpp.o (symbol from plugin): In function `operator new(unsigned int)':
(.text+0x0): multiple definition of `std::nothrow'
/tmp/arduino_build_fefirmware/libraries/ArduinoSTL/new_handler.cpp.o (symbol from plugin):(.text+0x0): first defined here
collect2: error: ld returned 1 exit status

I'm not sure why this didn't happen to me before, since it quite makes sense that it happens: Both Arduino (new.cpp, since merging arduino/ArduinoCore-avr#361) and ArduinoSTL (new_handler.cpp) declare the std::nothrow object. It's just a dummy, empty object, but the linker doesn't know this.

I'm not sure how to solve this, maybe it works to make it constexpr and declare it in the header rather than a .cpp file (and since it's empty and there is no reason to take the address of the object, it might not be emitted at all then), or maybe it should be an inline variable (but that's C++17)...