Skip to content
This repository was archived by the owner on Feb 21, 2022. It is now read-only.

Add stricts fixer #27

Merged
merged 1 commit into from
Nov 27, 2016
Merged

Add stricts fixer #27

merged 1 commit into from
Nov 27, 2016

Conversation

mmoreram
Copy link
Owner

  • Added StrictFixer for >=PHP7.0 applications
  • In configuration files you can define if all your files must be strict in types or not. You can
    define as well with a "~" value when you want to remove all entries, useful for <PHP7.0 applications

strict: true
strict: false
strict: ~

  • Fixed some strange behaviors in header fixer. Added some tests
  • Updated dependency to >=PHP7.1 >=SF3.0
  • Updated compiler to work with new Finder version

- Added StrictFixer for >=PHP7.0 applications
- In configuration files you can define if all your files must be strict in types or not. You can
  define as well with a "~" value when you want to remove all entries, useful for <PHP7.0 applications

strict: true
strict: false
strict: ~

- Fixed some strange behaviors in header fixer. Added some tests
- Updated dependency to >=PHP7.1 >=SF3.0
- Updated compiler to work with new Finder version
@mmoreram mmoreram force-pushed the feature/add-stricts branch from 0ebfcee to 5966b76 Compare November 26, 2016 00:14
@mmoreram
Copy link
Owner Author

@matt-usurp any feedback on that?

Copy link
Contributor

@matt-usurp matt-usurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I have nothing to say as it looks simple enough.

Lots of cleanup made this pretty difficult to read (as in get to the parts that matter), but its nice cleanup either way.

@mmoreram
Copy link
Owner Author

mmoreram commented Nov 27, 2016

@matt-usurp yes, sorry, php-cs-fixer did the thing :'/

Okay then, merging.

Thanks!

@mmoreram mmoreram merged commit b8156d7 into master Nov 27, 2016
@mmoreram mmoreram deleted the feature/add-stricts branch November 27, 2016 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants