Skip to content
This repository was archived by the owner on Feb 21, 2022. It is now read-only.

Fixed strict type in PHP file #31

Merged
merged 1 commit into from
Dec 22, 2016
Merged

Fixed strict type in PHP file #31

merged 1 commit into from
Dec 22, 2016

Conversation

mmoreram
Copy link
Owner

No description provided.

@matt-usurp
Copy link
Contributor

I made these changes to my local vendor manually and this does not fix the issue.

The change needs to happen in here too as mentioned in the issue #30.

https://github.com/mmoreram/php-formatter/blob/v1.3.1/src/PHPFormatter/Console/Application.php#L34-L37

if (function_exists('ini_set') && extension_loaded('xdebug')) {
    ini_set('xdebug.show_exception_trace', false);
    ini_set('xdebug.scream', false);
}

@mmoreram
Copy link
Owner Author

Hum, I don't have xdebug installed. True :(

@mmoreram mmoreram force-pushed the fix/fixed-strict-types branch from 5d00f36 to 5d0e72e Compare December 22, 2016 14:31
@mmoreram
Copy link
Owner Author

@matt-usurp updated :)

Copy link
Contributor

@matt-usurp matt-usurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks good to me now! Thanks :)

@mmoreram mmoreram merged commit 88768ac into master Dec 22, 2016
@mmoreram mmoreram deleted the fix/fixed-strict-types branch December 22, 2016 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants