Skip to content

Improve exception diagnostics for stdio client #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

Improve exception diagnostics for stdio client #376

merged 2 commits into from
May 14, 2025

Conversation

stephentoub
Copy link
Contributor

@stephentoub stephentoub commented May 1, 2025 •
edited
Loading

Closes #362

@stephentoub stephentoub requested a review from halter73 May 1, 2025 22:16
halter73
halter73 reviewed May 1, 2025
View reviewed changes
@stephentoub
Improve exception diagnostics for stdio client
201f05d 
Track the last several lines of stderr and include those in an exception created as part of CleanupAsync if the server process has already exited. This is based on an assumption that the server should never exit prior to CleanupAsync being called.
@stephentoub
Address feedback and fix test failure
b0ece50
@stephentoub stephentoub merged commit c11c634 into modelcontextprotocol:main May 14, 2025
7 checks passed
@stephentoub stephentoub deleted the stdiodiag branch May 14, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide better diagnostics than "The server shut down unexpectedly."
2 participants
@stephentoub @halter73