Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, the URL resolving is broken under different circumstances when adding a base URL to the path.
There are quite a few issues regarding this in this repo, but also in the Spring AI repos. Example: #261
Basically, the main issue is that the
resolveUri
method works for the message endpoint, but not for the SSE endpoint. So an URL resolver for the SSE endpoint is added.How Has This Been Tested?
See
WebMvcSseCustomPathIntegrationTests
Types of changes
Checklist
Open questions
This PR is currently WIP, because for now it is a little bit unclear for how to handle the context path.
I guess this is not the same as the
baseUrl
, but the main path of the servlet to reach? As an example, for SSE we would get:If this is correct, then some additional changes need to be made to support this.