Skip to content

Fix typo & Remove a useless instance and finalize the injecting property #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

echo-youn
Copy link

@echo-youn echo-youn commented May 27, 2025

Fix typo deafault.. into default.
Remove a useless instance and finalize the injecting property.

I remain wrong class for backward capabilities as deprecated

Motivation and Context

Correcting a typo to maintain consistency and avoid any potential misunderstanding.
Replacing field with constructor injection and marked the property as final for better immutability and testability.

How Has This Been Tested?

I test initiate server sync and async both. It was run correctly.

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant