Skip to content

Format files with ruff #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Format files with ruff #562

merged 1 commit into from
Apr 23, 2025

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented Apr 22, 2025

Noticed there are two unformatted files that keep popping in when I run uv run ruff format .

@ihrpr ihrpr requested a review from dsp-ant April 22, 2025 09:14
@jerome3o-anthropic jerome3o-anthropic merged commit b4c7db6 into main Apr 23, 2025
8 checks passed
@jerome3o-anthropic jerome3o-anthropic deleted the ihrpr/format-and-tests branch April 23, 2025 04:06
@Kludex
Copy link
Member

Kludex commented Apr 24, 2025

Why is this mismatch happening?

@Kludex
Copy link
Member

Kludex commented Apr 24, 2025

We are running this in the pipeline:

- name: Run ruff format check
run: uv run --no-sync ruff check .

...and this locally:

hooks:
- id: ruff-format
name: Ruff Format
entry: uv run ruff
args: [format]
language: system
types: [python]
pass_filenames: false
- id: ruff
name: Ruff
entry: uv run ruff
args: ["check", "--fix", "--exit-non-zero-on-fix"]
types: [python]
language: system
pass_filenames: false

We need to match both. We need to run the pre-commit job on the pipeline as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants