-
Notifications
You must be signed in to change notification settings - Fork 79
added ok-computer #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ok-computer #865
Conversation
Not sure why ok-computer is so slow as, although I haven't / don't intend to make micro optimisations, it's running significantly slower than others; I'll follow up with a new version once I've done some optimisation. |
@richardscarrott See #864, which might affect the benchmarks. @hoeck has a PR for this in #866, which will get out soon, so might want to wait for that and retry your benchmarks. Cheers and thanks for this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change though. We pin the exact version to make sure that we record the bench results against the exact version.
@moltar I did some profiling this morning and found it was genuinely slower than it should have been as it was hitting a catch block frequently. I made a fix here richardscarrott/ok-computer#7 and sent an update to the benchmarks here #869 -- something I wouldn't have prioritised if you hadn't made this project 👍 |
Awesome!! |
#696