-
Notifications
You must be signed in to change notification settings - Fork 52
DOCSP-25770: TLS setup #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! The suggestions were just off the top of my head, so feel free to change as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + suggestions
const { MongoClient } = require("mongodb"); | ||
const fs = require("fs"); | ||
const tls = require("tls"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const { MongoClient } = require("mongodb"); | |
const fs = require("fs"); | |
const tls = require("tls"); | |
import { MongoClient } from "mongodb"; | |
import * as fs from "fs"; | |
import * as tls from "tls"; |
I think we use import syntax in our examples now mostly right? This is just a best practices thing, most users know how to translate between the two but we can save them an extra step (TS users likely want to see ^ this format)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have code examples in JS and TS? Or at least include a note that the example is in TS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is necessary, we have this on the "How to Use the Usage Examples"
All examples use ES module imports. You can enable ES module imports by adding the following key-value pair to your package.json file:
https://www.mongodb.com/docs/drivers/node/current/usage-examples/#how-to-use-the-usage-examples
So we should stick to import syntax, it is not the default yet, but it is becoming the defacto standard for folks TS or JS, so we can just write code the modern way.
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5) (cherry picked from commit 05b5167)
* DOCSP-25770: TLS connection * first draft * TOC * first pass fixes * small fixes * change header levels * orient page around production * fixes * MW PR fixes 1 * wiki link fixes * MW PR fixes 2 * fixes * MW suggestions * NB PR fixes 1 * small fixes (cherry picked from commit cafe9c5)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-25770
Staging
Self-Review Checklist