Skip to content

DOCSP-25770: TLS setup #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 1, 2023
Merged

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Apr 26, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-25770
Staging

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! The suggestions were just off the top of my head, so feel free to change as needed.

@rustagir rustagir requested a review from mongoKart April 28, 2023 14:19
@rustagir rustagir requested a review from mongoKart April 28, 2023 19:55
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + suggestions

Comment on lines 244 to 246
const { MongoClient } = require("mongodb");
const fs = require("fs");
const tls = require("tls");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const { MongoClient } = require("mongodb");
const fs = require("fs");
const tls = require("tls");
import { MongoClient } from "mongodb";
import * as fs from "fs";
import * as tls from "tls";

I think we use import syntax in our examples now mostly right? This is just a best practices thing, most users know how to translate between the two but we can save them an extra step (TS users likely want to see ^ this format)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have code examples in JS and TS? Or at least include a note that the example is in TS?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is necessary, we have this on the "How to Use the Usage Examples"

All examples use ES module imports. You can enable ES module imports by adding the following key-value pair to your package.json file:

https://www.mongodb.com/docs/drivers/node/current/usage-examples/#how-to-use-the-usage-examples

So we should stick to import syntax, it is not the default yet, but it is becoming the defacto standard for folks TS or JS, so we can just write code the modern way.

@rustagir rustagir merged commit cafe9c5 into mongodb:master May 1, 2023
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
rustagir added a commit that referenced this pull request May 1, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
(cherry picked from commit 05b5167)
jordan-smith721 pushed a commit to jordan-smith721/docs-node that referenced this pull request Jul 24, 2023
* DOCSP-25770: TLS connection

* first draft

* TOC

* first pass fixes

* small fixes

* change header levels

* orient page around production

* fixes

* MW PR fixes 1

* wiki link fixes

* MW PR fixes 2

* fixes

* MW suggestions

* NB PR fixes 1

* small fixes

(cherry picked from commit cafe9c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants